Ensure IAC_SCAN is included when --detect.tools=ALL #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrian-sevastyanov
requested review from
dterrybd,
gopannabd,
shantyk,
devmehtabd and
zahidblackduck
| @@ -50,9 +47,6 @@ public boolean shouldInclude(DetectTool detectTool) { //Only turn tools OFF, tur | |||
| if (detectTool == DetectTool.IMPACT_ANALYSIS) { | |||
| return impactEnabled; | |||
| } | |||
| if (detectTool == DetectTool.IAC_SCAN) { | |||
There was a problem hiding this comment.
Since this check is being removed, the decision will be made primarily by line 69 in this file.
Check at line 53 will not matter here since Rapid mode does not attempt IaC.
I am looking into whether the check at line 56 is something to take into account here since I don't fully understand stateless mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure IAC_SCAN is included when --detect.tools=ALL and --detect.iac.scan.paths is not specified.