Skip to content

OTWO-7508 added return statement if code_set_ids is blank #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2025
Merged

OTWO-7508 added return statement if code_set_ids is blank #1848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/models/analysis/query_base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,10 @@ def with_analysis
activity_facts[:on_trunk].eq(true).and(activity_facts[:analysis_id].eq(@analysis.id))
end

# rubocop:disable Metrics/MethodLength
def contributor_monthly_commits_query(code_set_ids)
return [] if code_set_ids.blank?

commit_name_ids = AnalysisAlias.where(preferred_name_id: @name_id, analysis_id: @analysis.id).pluck(:commit_name_id)
sql = <<-SQL.squish
select to_char(date(C.time),'MON,YYYY') as month, count (*) as count
Expand All @@ -101,4 +104,5 @@ def contributor_monthly_commits_query(code_set_ids)
data = commit_name_ids.present? ? ApplicationRecord.connection.execute(sql).try(:to_json) : commit_name_ids.to_s
JSON.parse(data)
end
# rubocop:enable Metrics/MethodLength
end