Feature: Faster BMP -> BMDA communications #1722
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
After having a couple of conversations with ALTracer about the speed and performance of BMDA interacting with the firmware, we realised that the current 1-byte-at-a-time solution for reads, while correct, is extremely far from performant but there's a simple solution to the problem that doesn't sacrifice correctness - slipping a large buffer in between the reads and the reading.
This PR addresses this by adding a 4KiB buffer in between the probe reads and BMDA's platform_buffer_read() on both Linux/macOS and Windows. This significantly reduces the number of syscalls being made and streamlines the data transport through BMDA from the probe. A reasonable speedup on current firmware was observed with no drawbacks.
Your checklist for this pull request
make PROBE_HOST=native
)make PROBE_HOST=hosted
)Closing issues