Fix: semihosting cleanup #1730

dragonmux · 2024-01-14T02:03:38Z

Detailed description

This PR aims to clean up the semihosting implementation, eliminating unnecessary functions and refactoring the giant switch-case into proper functional blocks that can then be fixed and are easier to understand.

This is the second in a series of 3 semihosting PRs designed to fix and improve the implementation ready for it to be used by RISC-V, Cortex-A/R and other future architectures.

This fixes some bugs in the implementation involving SYS_TMPNAM, SYS_EXIT, and some of the other syscalls. These have been tested against both Koen's semihosting test firmware and the firmware now available in the HITL firmware repo.

Your checklist for this pull request

I've read the Code of Conduct
I've read the guidelines for contributing to this repository
It builds for hardware native (see Building the firmware)
It builds as BMDA (see Building the BMDA)
I've tested it to the best of my ability
My commit messages provide a useful short description of what the commits do

Closing issues

… function

…ihosting intercept

…w function

… function

…w function

…ew function

…w function

… function

…nction

…ew function

… function

…w function

… function

…w function

…open()`

…_close()`

…_seek()`

…g_rename()`

…g_remove()`

…g_system()`

…g_isatty()`

…hosting_get_time()`

…_file_length()`

…hosting handler and moved it back to cortexm.c

…o a new function

…ew function

… new function

…new function

…w function

esden

LGTM

dragonmux added 30 commits January 14, 2024 02:03

semihosting: Began fixing nomenclature

ca27e12

semihosting: Refactored out the SEMIHOSTING_SYS_OPEN logic into a new…

12e7935

… function

semihosting: Implemented a structure for holding the details of a sem…

e599619

…ihosting intercept

semihosting: Refactored out the SEMIHOSTING_SYS_CLOSE logic into a ne…

5a3c19a

…w function

semihosting: Refactored out the SEMIHOSTING_SYS_READ logic into a new…

d11e120

… function

semihosting: Refactored out the SEMIHOSTING_SYS_WRITE logic into a ne…

479692b

…w function

semihosting: Refactored out the SEMIHOSTING_SYS_WRITEC logic into a n…

baac18b

…ew function

semihosting: Refactored out the SEMIHOSTING_SYS_WRITE0 logic into a n…

e98884c

…ew function

semihosting: Refactored out the SEMIHOSTING_SYS_ISTTY logic into a ne…

87be761

…w function

semihosting: Refactored out the SEMIHOSTING_SYS_SEEK logic into a new…

56d1d9c

… function

semihosting: Refactored out the file name readout logic into a new fu…

36622dc

…nction

semihosting: Refactored out the SEMIHOSTING_SYS_RENAME logic into a n…

6e126d1

…ew function

semihosting: Refactored out the SEMIHOSTING_SYS_REMOVE logic into a n…

eee159f

…ew function

semihosting: Refactored out the SEMIHOSTING_SYS_SYSTEM logic into a n…

7efdffc

…ew function

semihosting: Refactored out the SEMIHOSTING_SYS_FLEN logic into a new…

d1d7125

… function

semihosting: Refactored out the SEMIHOSTING_SYS_CLOCK logic into a ne…

6c6d158

…w function

semihosting: Refactored out the SEMIHOSTING_SYS_TIME logic into a new…

590dd86

… function

semihosting: Refactored out the SEMIHOSTING_SYS_READC logic into a ne…

b9e8685

…w function

semihosting: Cleaned up the SEMIHOSTING_SYS_ERRNO logic

f2340ea

semihosting: Eliminated hostio_open() by inling it in `semihosting_…

705af7e

…open()`

semihosting: Eliminated hostio_close() by inling it in `semihosting…

f6cc2ad

…_close()`

semihosting: Eliminated hostio_write() by inling it in tc_write()

5df4eb7

semihosting: Eliminated hostio_lseek() by inling it in `semihosting…

3dc3774

…_seek()`

semihosting: Eliminated hostio_rename() by inling it in `semihostin…

85676e9

…g_rename()`

semihosting: Eliminated hostio_unlink() by inling it in `semihostin…

fe84181

…g_remove()`

semihosting: Eliminated hostio_system() by inling it in `semihostin…

d60b478

…g_system()`

semihosting: Eliminated hostio_isatty() by inling it in `semihostin…

a88d58a

…g_isatty()`

semihosting: Eliminated hostio_gettimeofday() by inling it in `semi…

fa5da9d

…hosting_get_time()`

semihosting: Eliminated hostio_fstat() by inling it in `semihosting…

984e10d

…_file_length()`

semihosting: Eliminated hostio_stat() as it's unused anywhere

c97df35

dragonmux added 9 commits January 14, 2024 02:03

semihosting: Types and static fixes

18f2189

semihosting: Split out the Cortex-M specific stuff from the main semi…

5bd0415

…hosting handler and moved it back to cortexm.c

semihosting: Cleanup in the main request handler

644c147

semihosting: Refactored out the SEMIHOSTING_SYS_GET_CMDLINE logic int…

94e56b6

…o a new function

semihosting: Refactored out the SEMIHOSTING_SYS_TMPNAM logic into a n…

c177364

…ew function

semihosting: Refactored out the SEMIHOSTING_SYS_HEAPINFO logic into a…

c2dfb8a

… new function

semihosting: Refactored out the SEMIHOSTING_SYS_ISERROR logic into a …

67e1d19

…new function

semihosting: Refactored out the SEMIHOSTING_SYS_EXIT* logic into a ne…

a4bd7e5

…w function

semihosting: Cleaned up the request handler function

81b0393

dragonmux added Bug Confirmed bug Enhancement General project improvement labels Jan 14, 2024

dragonmux added this to the v2.0 release milestone Jan 14, 2024

dragonmux requested a review from esden January 14, 2024 02:03

esden approved these changes Jan 14, 2024

View reviewed changes

esden merged commit 81b0393 into main Jan 14, 2024
17 checks passed

dragonmux deleted the fix/semihosting-cleanup branch January 14, 2024 02:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: semihosting cleanup #1730

Fix: semihosting cleanup #1730

dragonmux commented Jan 14, 2024

esden left a comment

Fix: semihosting cleanup #1730

Fix: semihosting cleanup #1730

Conversation

dragonmux commented Jan 14, 2024

Detailed description

Your checklist for this pull request

Closing issues

esden left a comment

Choose a reason for hiding this comment