-
-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: CMSIS-DAP packet size handling #1731
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonmux
added
Bug
Confirmed bug
Enhancement
General project improvement
BMD App
Black Magic Debug App (aka. PC hosted) (not firmware)
labels
Jan 14, 2024
dragonmux
force-pushed
the
fix/cmsis-dap-packet-size-handling
branch
from
January 14, 2024 02:17
0562c9f
to
90749dc
Compare
…d the default "report size"
…CMSIS-DAP probe supports
dragonmux
force-pushed
the
fix/cmsis-dap-packet-size-handling
branch
from
January 14, 2024 03:39
90749dc
to
609cfc8
Compare
esden
requested changes
Jan 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just found one little oddness otherwise it looks good.
dragonmux
force-pushed
the
fix/cmsis-dap-packet-size-handling
branch
from
January 14, 2024 03:52
609cfc8
to
63dba12
Compare
esden
approved these changes
Jan 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
BMD App
Black Magic Debug App (aka. PC hosted) (not firmware)
Bug
Confirmed bug
Enhancement
General project improvement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
This PR fixes the way the CMSIS-DAP code handles adaptor packet sizing and the differences between HID and Bulk endpoint (v1 and v2) based firmware.
Tested working against ORBTrace and picoprobe (which is based directly on the ARM reference implementation).
This finally solves the mystery too of how the packet size and buffer interact with one another and the HIDAPI code, documenting this properly.
Your checklist for this pull request
Closing issues