Initial merge of Wi-Fi support code for ctxLink. #1927
+2,756
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonmux
added
Enhancement
sidprice
force-pushed
the
ctxLink_wifi
branch
3 times, most recently
from
ed23bcf
to
66d60b2
Compare
sidprice
force-pushed
the
ctxLink_wifi
branch
from
66d60b2
to
b7da541
Compare
dragonmux
requested changes
Sep 29, 2024
sidprice
force-pushed
the
ctxLink_wifi
branch
2 times, most recently
from
18e79dd
to
5a7a3d1
Compare
dragonmux
reviewed
Oct 2, 2024
There was a problem hiding this comment.
With this review, we have only the WiFi server implementation to review and we think we've covered most of the rest. Some of the comments likely apply across multiple files, so if you see, eg, u_int32_t in another file to the one commented in, then our uint32_t comment applies to it as well.
| bool is_swo_trace_client_connected(void); | ||
| void send_swo_trace_data(uint8_t *lpBuffer, uint8_t length); | ||
|
|
||
| void wifi_gdb_putchar(unsigned char ch, int flush); |
There was a problem hiding this comment.
We believe that flush should be bool here - you'll need to #include <stdbool.h> at the top of the file for that but it should otherwise be good to go.
There was a problem hiding this comment.
This function is based up the common/stm32/gdb_if.c file, which as:
void gdb_if_putchar(const char c, const int flush)
sidprice
force-pushed
the
ctxLink_wifi
branch
2 times, most recently
from
613870d
to
6bfc7f9
Compare
dragonmux
reviewed
Oct 3, 2024
sidprice
force-pushed
the
ctxLink_wifi
branch
5 times, most recently
from
ba7c432
to
761cb41
Compare
This is in preparation for updating the GDB I/O functions to handle both USB and WiFi connections.
Other compilation issues address in this commit.
Removed the winc1500 library sources, kept the API stub file in the ctxlink directory. It was not part of the winc1500 library.
Also fix local variable "count" to match sscanf return type.
…attribute. Also, simplify the access function.
Also, add define for RX/TX buffer sizes for clarity
…ariable declaration to file beginning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
This PR brings an early version of Wi-Fi support for ctxLink. Initially, it attempts to update the souce code to fit more closely with the style of BMF source code as definied by Clang-Tidy.
The built firmware, while offering initiall Wi-Fi connectivity and operation, is not full featured. The intent of this PR is to allow outstanding features in smaller PRs, thus reducing the burden on the author and the reviewer.
Your checklist for this pull request
Closing issues
None