Skip to content
This repository was archived by the owner on Mar 7, 2026. It is now read-only.

Add ESP32-P4 support#2063

Closed
orsolic wants to merge 5 commits intoblackmagic-debug:mainfrom
orsolic:esp32p4
Closed

Add ESP32-P4 support#2063
orsolic wants to merge 5 commits intoblackmagic-debug:mainfrom
orsolic:esp32p4

Conversation

@orsolic
Copy link
Copy Markdown

@orsolic orsolic commented Jan 25, 2025

Here is commit with start of support for ESP32-P4.

I have started working on flashing support but I need to shelve that plan for the time being.
I am pushing the things which seems to work - patch is rough, but more will hopefully come later.

Tested with BMA and ESP-prog (FT2232H) on FreeBSD with Waveshare ESP32-P4 board with flashed IDF example.

Works:

  • JTAG scan
  • attach to target
  • run program
  • reset
  • hardware breakpoint
  • continue
  • printing of var in SRAM
>>> p var
$4 = 123
>>> p &var
$5 = (uint32_t *) 0x4ff26334
>>> x /d 0x4ff26334
0x4ff26334:     123
  • changing value of var:
>>> set var var = 100
>>> p var
$8 = 100
>>> x /d 0x4ff26334
0x4ff26334:     100

What doesn't work:

  • software breakpoint (needs flash support)
  • stepping
  • single instruction stepping

@orsolic
jtag_scan: add workaround for ESP32-P4 which has two ir_value
43014c9
@orsolic
ESP32-P4: Add JTAG IDs
8944f4e 
Tested on BMA, after jtag_scan:
ID code 0x00012c25: ESP32-P4
ID code 0x00012c25: ESP32-P4
RISC-V debug v0.13/v1.0 DMI
RISC-V debug v0.13 DM
Skipping hart 0 -> Unavailable
RISC-V debug v0.13/v1.0 DMI
@orsolic
riscv_debug: Turn on DM before trying to read version
e526508 
According to the RISC-V debug specification, DM must be turned on before
accessing DM registers (like reading version of DM).
This fixes attaching to target
@orsolic
Fix FreeBSD build
aca7c43
dragonmux
dragonmux suggested changes Jan 26, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks interesting - there are some issues though, particular involving repeated scans within a session. Please see our review notes for details.

@dragonmux dragonmux added this to the v2.1 release milestone Jan 26, 2025
@dragonmux dragonmux added the New Target New debug target label Jan 26, 2025
@orsolic
Copy link
Copy Markdown
Author

orsolic commented Jan 27, 2025

Thanks for the review!
I've force pushed the updated changes.

@orsolic orsolic closed this Jan 27, 2025
@orsolic orsolic deleted the esp32p4 branch January 27, 2025 20:41
@orsolic
Copy link
Copy Markdown
Author

orsolic commented Jan 27, 2025

I've accidentally pushed the wrong branch (the one with included FreeBSD build fix), then deleted it, which caused this PR to be closed, and now I can't reopen it.
Can you reopen it? Or, should I create a new PR?

@esden
Copy link
Copy Markdown
Member

esden commented Jan 27, 2025

The problem is that you deleted the branch on your repository, so this PR does not have anything to reference to. I think you will have to open a new pull request.

@orsolic orsolic mentioned this pull request Jan 28, 2025
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dragonmux dragonmux dragonmux requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

New Target New debug target

Projects

None yet

Milestone

v2.1 release

Development

Successfully merging this pull request may close these issues.

3 participants

@orsolic @esden @dragonmux