fixing tsconfig.json

[GottZ]

as #2271 is fixing the linting error from #2266, this will fix another issue with tsconfig.json.

sourceMap and inlineSourceMap can't be combined technically.

[holroy]

Why have all these commits been forced pushed like this? (Instead of being a normal pull request?)

And do you have write access to this repository? Do you potentially know who has write access besides @blacksmithgu ?

[GottZ]

Why have all these commits been forced pushed like this? (Instead of being a normal pull request?)

I know git pretty well.
essentially I'm only force pushing to my own fork.
if you do a pull request, as long as it is not merged yet, you can change 100% of the history that is to be pulled when a maintainer hits merge.
even amending or squashing your own commits, to reduce commit count, will result in requiring force pushes.
a force push is usually considered a bad thing, if you actually have people relying on your repo.
for example: if you would base your branches off my master, tomorrow your repo would likely experience the inability to pull from me, after I did another history rewrite.

as you can see, now this pull request just contains a single line change in a single commit.
when it's merged, it will forget about all the force pushes I did to my repo.

And do you have write access to this repository? Do you potentially know who has write access besides @blacksmithgu ?

sadly not.
I already fear that my pace is a little overwhelming.

[GottZ]

@holroy i also rebase to master every time master is updated through merged pull requests.
if you'd plot it visually, my pull requests always look like they have just been made on top of the current master head.

[holroy]

Hmm... Personally I think your policy of force pushing the commits like that hides away some of the changes and the process of how one arrives at a given code version. But YMMV, and you're of course free to choose your way of doing stuff like this.

[Cephra]

@holroy a force push is necessary if you rebase your own commits locally, which have been already pushed before. Then there's a mismatch between your local state and remote state, which requires a force push.

[Cephra]

Also Hey @GottZ :)

[GottZ]

Also Hey @GottZ :)

LOL! hi there. I definitely did not expect you here.

also.. to be fair, originally this was a PR changing tons of files.