Add overflow-x auto to codeblocks #2270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GottZ
added a commit
to GottZ/obsidian-dataview
that referenced
this pull request
Mar 17, 2024
GottZ
force-pushed
the
add-codeblock-scrollx
branch
2 times, most recently
from
5bec3f4 to
0dce1de
Compare
|
I'm a bit behind here - is there a reason we can't fix this just with a plain CSS block and need this style provider logic? |
GottZ
added a commit
to GottZ/obsidian-dataview
that referenced
this pull request
Mar 20, 2024
GottZ
force-pushed
the
add-codeblock-scrollx
branch
from
0dce1de to
3954c73
Compare
GottZ
force-pushed
the
add-codeblock-scrollx
branch
from
3954c73 to
aa6b933
Compare
|
@blacksmithgu it was basically for something else I was going to add down the line but you are right.. it's now a two line addition. also in regards to:
as long as you allow people to dynamically rename dataviewjs to something else, no. |
GottZ
changed the title
blacksmithgu
approved these changes
Mar 22, 2024
GottZ
added a commit
to GottZ/obsidian-dataview
that referenced
this pull request
Mar 23, 2024
GottZ
added a commit
to GottZ/obsidian-dataview
that referenced
this pull request
Apr 11, 2024
GottZ
added a commit
to GottZ/obsidian-dataview
that referenced
this pull request
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2220
closes #2022
closes #844
Hello there.
this is the a step towards syntax highlighting in dataview blocks.
as it currently is implemented, it fixes the above linked issue.
this gem will adapt styles based on plugin settings in real time with high efficiency:
