critical api fix: verNum should not be undefined #2278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GottZ
force-pushed
the
fix-version-check
branch
from
66ef459
to
5895c73
Compare
blacksmithgu
approved these changes
Mar 23, 2024
|
I actually worked a little on this thingy tonight, and when I'd found a solution I couldn't find the bug anymore since you guys had already fixed it. 🥲 I did push the changes to my local fork, which is shown above, and that wasn't really the plan, but github decided to link it, so there it is. It can be ignored, unless this bug resurfaces again on a later stage. |
|
It's definitely very strange... I do wonder what changed to break this. |
|
I'll continue talking about it in the linked issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2276
this breaks excalibrain and other plugins that use the api to compare versions.
for some strange reason, closures like that now run pre-constructor so verNum is not defined at that point in time.
must be related to a change in electron / v8 or how the plugin builds.