feat: add falcon_detection_details datasource #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrew-Morozko
approved these changes
Oct 17, 2024
Comment on lines
32
to
35
| Name: "size", | ||
| Type: cty.Number, | ||
| Constraints: constraint.Integer | constraint.RequiredNonNull, | ||
| Doc: "limit the number of queried items", |
There was a problem hiding this comment.
Perhaps the size should have a default value
Suggested change
| Name: "size", | |
| Type: cty.Number, | |
| Constraints: constraint.Integer | constraint.RequiredNonNull, | |
| Doc: "limit the number of queried items", | |
| Name: "limit", | |
| Type: cty.Number, | |
| Constraints: constraint.Integer | constraint.NonNull, | |
| Doc: "Maximum number of returned items", | |
| DefaultVal: cty.NumberIntVal(50), | |
| MinInclusive: cty.NumberIntVal(1), |
I guess that having a default limit would be a bit neater from the UX standpoint, as well as naming it "limit" rather than "size". @traut what do you think?
There was a problem hiding this comment.
I agree, let me update all prs
This was referenced Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/#243