Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: microsoft_security and microsoft_security_query data sources in microsoft plugin #261

Merged
merged 14 commits into from
Nov 17, 2024

Conversation

traut
Copy link
Member

@traut traut commented Nov 9, 2024

  • slightly refactored client init
  • added 2 new data sources - microsoft_security and microsoft_security_query
    • microsoft_security facilitates requests against https://api.securitycenter.microsoft.com/api endpoints
    • microsoft_security_query allows Advanced Hunting Query execution against https://api.securitycenter.microsoft.com/api/advancedqueries/run endpoint. The endpoint is somewhat special, so it has its own data source

Following up on the work done in #241 and #129

@traut traut changed the title Microsoft plugin cleanup and microsoft_security data source Microsoft plugin cleanup and new data sources Nov 14, 2024
@traut traut changed the title Microsoft plugin cleanup and new data sources feat: microsoft_security and microsoft_security_query data sources in microsoft plugin Nov 14, 2024
@traut traut marked this pull request as ready for review November 14, 2024 19:14
@traut traut requested review from dobarx and Andrew-Morozko and removed request for dobarx November 14, 2024 19:14
@dobarx
Copy link
Contributor

dobarx commented Nov 15, 2024

Looks good! Just tests failing in internal/microsoft package:

# github.com/blackstork-io/fabric/internal/microsoft_test [github.com/blackstork-io/fabric/internal/microsoft.test]
internal/microsoft/content_azure_openai_text_test.go:31:23: undefined: client_mocks.AzureOpenaiClient
internal/microsoft/content_azure_openai_text_test.go:46:24: undefined: client_mocks.AzureOpenaiClient

@traut
Copy link
Member Author

traut commented Nov 16, 2024

@dobarx oh, apologies, fixed

@traut traut merged commit 1c42837 into main Nov 17, 2024
24 checks passed
@traut traut deleted the microsoft-apis branch November 17, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants