Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebranding 1 rebased #30

Merged
merged 16 commits into from
Oct 17, 2024
Merged

Rebranding 1 rebased #30

merged 16 commits into from
Oct 17, 2024

Conversation

Norrox
Copy link

@Norrox Norrox commented Oct 16, 2024

#12

@Norrox Norrox mentioned this pull request Oct 16, 2024
Closed
@flare199
Copy link

Did you change an alarm log message to spanish in platform/android/java/lib/src/org/godotengine/godot/GodotDownloaderAlarmReceiver.java?

@sshiiden
Copy link
Member

Did you change an alarm log message to spanish in platform/android/java/lib/src/org/godotengine/godot/GodotDownloaderAlarmReceiver.java?

I checked, it was already in spanish.

@Norrox
Copy link
Author

Norrox commented Oct 16, 2024 •
edited
Loading

Did you change an alarm log message to spanish in platform/android/java/lib/src/org/godotengine/godot/GodotDownloaderAlarmReceiver.java?
@flare199

it was spanish original, but i changed it to english and it broke everything xD
so i changed it back :P

@Bioblaze
Copy link
Member

Wait what?! it was in spanish to begin with? and then broke?!?!?!
What was the error of the failed test when it broke?

@Norrox
Copy link
Author

Norrox commented Oct 17, 2024

Wait what?! it was in spanish to begin with? and then broke?!?!?! What was the error of the failed test when it broke?
image
image

@Norrox
Copy link
Author

Norrox commented Oct 17, 2024

Think this is ready for merge when the tests are good?

@Bioblaze Bioblaze merged commit dbb5a2e into blazium-engine:blazium-dev Oct 17, 2024
22 checks passed
@Norrox Norrox deleted the rebranding-1-rebased branch October 17, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jss2a98aj jss2a98aj jss2a98aj requested changes

@sshiiden sshiiden sshiiden approved these changes

@flare199 flare199 flare199 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Norrox @flare199 @sshiiden @Bioblaze @jss2a98aj