Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BottomPanel excessive width. #43

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Fix BottomPanel excessive width. #43

merged 2 commits into from
Oct 18, 2024

Conversation

WhalesState
Copy link

You can have as many BottomPanel plugins as you want!

BlaziumBottomPanel.mp4

Copy link
Member

@jss2a98aj jss2a98aj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look like it will be a really nice feature. One of the tooltips should probably be tweaked slightly, but otherwise I did not notice any issues.

editor/gui/editor_bottom_panel.cpp Outdated Show resolved Hide resolved
@Starkium
Copy link

Starkium commented Oct 17, 2024

looks like there's a typo

  • left_button->set_tooltip_text(TTR("Scroll Left\nHold Ctrl to scroll to the begining.\nHold Shift to scroll one page."));
  • left_button->set_tooltip_text(TTR("Scroll Left\nHold Ctrl to scroll to the beginning.\nHold Shift to scroll one page."));

@jss2a98aj
Copy link
Member

looks like there's a typo

  • left_button->set_tooltip_text(TTR("Scroll Left\nHold Ctrl to scroll to the begining.\nHold Shift to scroll one page."));

  • left_button->set_tooltip_text(TTR("Scroll Left\nHold Ctrl to scroll to the beginning.\nHold Shift to scroll one page."));

That typo was my fault, I had it messed up when suggesting a change.

@Starkium
Copy link

someone stopped the tests. I'll rerun this again once those are done

@jss2a98aj
Copy link
Member

someone stopped the tests. I'll rerun this again once those are done

Those stopped automatically when the static check failed from the typo.

@@ -255,9 +297,35 @@ EditorBottomPanel::EditorBottomPanel() {
bottom_hbox->set_custom_minimum_size(Size2(0, 24 * EDSCALE)); // Adjust for the height of the "Expand Bottom Dock" icon.
item_vbox->add_child(bottom_hbox);

left_button = memnew(Button);
left_button->set_tooltip_text(TTR("Scroll Left\nHold Ctrl to scroll to the begining.\nHold Shift to scroll one page."));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spell check linter "beginning"

Signed-off-by: Aaron Benjamin <lifeartstudios@gmail.com>
@Starkium Starkium merged commit 02698c9 into blazium-engine:blazium-dev Oct 18, 2024
22 checks passed
@WhalesState WhalesState deleted the some-gui-fixes branch October 18, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants