default color for preview environment #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshiiden
approved these changes
Oct 17, 2024
Starkium
approved these changes
Oct 18, 2024
jss2a98aj
requested changes
Oct 18, 2024
There was a problem hiding this comment.
Being able to set a horizion color is great. I do not think defaulting sky, ground, and horizon colors all to the same color is good. Keeping purple for the horizon, but reverting sky and ground colors would look nicer and be a more developer friendly default.
Reverting the two suggested colors would look like this:
|
Im all for having different colors, but please. No poop color on the ground 😂🙈 |
|
I can suggest Examples from unreal and unity
|
|
Something like |
RandomOfNoWhere
approved these changes
Oct 18, 2024
Yeah that can work! i'll change it! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added an default color for preview environment and a button to change horizon color