Change the default theme colors. #61
Conversation
WhalesState
commented
Oct 18, 2024
WhalesState
commented
| @@ -250,7 +250,7 @@ EditorThemeManager::ThemeConfiguration EditorThemeManager::_create_theme_config( | |||
| config.color_picker_button_height = 28 * EDSCALE; | |||
| config.subresource_hue_tint = EDITOR_GET("docks/property_editor/subresource_hue_tint"); | |||
|
|
|||
| config.default_contrast = 0.3; // Make sure to keep this in sync with the editor settings definition. | |||
| config.default_contrast = 0.24; // Make sure to keep this in sync with the editor settings definition. | |||
There was a problem hiding this comment.
Multiple themes use the default contrast, please adjust them accordingly so they do not have unintended visual changes.
There was a problem hiding this comment.
I gave the other themes that was using the default contrast a 0.3 value, also removed redot and blazium presets, we already are the default so we don't need to add a preset.
| @@ -7061,6 +7061,7 @@ EditorNode::EditorNode() { | |||
| scene_root_parent->set_v_size_flags(Control::SIZE_EXPAND_FILL); | |||
|
|
|||
| scene_root = memnew(SubViewport); | |||
| scene_root->set_transparent_background(true); | |||
There was a problem hiding this comment.
Why is this line being added?
There was a problem hiding this comment.
this is for the CanvasItemEditor viewport background color, without it, the background will always be gray and will not follow the theme colors when we change it, we can't override the default_clear_color for the viewport with every release, so it's better to use a transparent background instead for the 2D editor.
There was a problem hiding this comment.
That is a fine reason. I am curious if it would have any impact on performance or battery life when using the editor on mobile though.
There was a problem hiding this comment.
It shouldn't have any impact on performance, the rendering server will not draw a clear color for the CanvasItemEditor SubViewport.
|
lol funny how we removed the redot theme XD |
