fix: use non-inclusive chain iterator for chainsync

blockfetch.go

@@ -39,7 +39,7 @@ func (n *Node) blockfetchServerRequestRange(
 	end ocommon.Point,
 ) error {
 	// TODO: check if we have requested block range available and send NoBlocks if not
-	chainIter, err := n.ledgerState.GetChainFromPoint(start)
+	chainIter, err := n.ledgerState.GetChainFromPoint(start, true)
 	if err != nil {
 		return err
 	}

chainsync/chainsync.go

@@ -70,7 +70,7 @@ func (s *State) AddClient(
 	s.Lock()
 	defer s.Unlock()
 	// Create initial chainsync state for connection
-	chainIter, err := s.ledgerState.GetChainFromPoint(intersectPoint)
+	chainIter, err := s.ledgerState.GetChainFromPoint(intersectPoint, false)
 	if err != nil {
 		return nil, err
 	}

state/chain.go

@@ -35,7 +35,7 @@ type ChainIteratorResult struct {
 	Rollback bool
 }
 
-func newChainIterator(ls *LedgerState, startPoint ocommon.Point) (*ChainIterator, error) {
+func newChainIterator(ls *LedgerState, startPoint ocommon.Point, inclusive bool) (*ChainIterator, error) {
 	ls.RLock()
 	defer ls.RUnlock()
 	// Lookup start block in metadata DB
@@ -51,6 +51,10 @@ func newChainIterator(ls *LedgerState, startPoint ocommon.Point) (*ChainIterator
 		startPoint:  startPoint,
 		blockNumber: tmpBlock.Number,
 	}
+	// Increment next block number is non-inclusive
+	if !inclusive {
+		ci.blockNumber++
+	}
 	return ci, nil
 }
 

state/state.go

@@ -392,9 +392,10 @@ func (ls *LedgerState) GetIntersectPoint(points []ocommon.Point) (*ocommon.Point
 	return nil, nil
 }
 
-// GetChainFromPoint returns a ChainIterator starting at the specified point
-func (ls *LedgerState) GetChainFromPoint(point ocommon.Point) (*ChainIterator, error) {
-	return newChainIterator(ls, point)
+// GetChainFromPoint returns a ChainIterator starting at the specified point. If inclusive true, the iterator
+// will start at the requested point, otherwise it will start at the next block.
+func (ls *LedgerState) GetChainFromPoint(point ocommon.Point, inclusive bool) (*ChainIterator, error) {
+	return newChainIterator(ls, point, inclusive)
 }
 
 // Tip returns the current chain tip