Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make client block buffer size larger to avoid deadlocks #67

Merged
merged 1 commit into from
Jun 24, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions chainsync/chainsync.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ import (
)

const (
maxRecentBlocks = 20 // Number of recent blocks to cache
maxRecentBlocks = 20 // Number of recent blocks to cache
clientBlockBufferSize = 50 // Size of per-client block buffer
)

var (
Expand Down Expand Up @@ -178,7 +179,7 @@ func (s *State) RemoveClientConnId(connId ouroboros.ConnectionId) {
}

func (s *State) sub(key ouroboros.ConnectionId) chan ChainsyncBlock {
tmpChan := make(chan ChainsyncBlock, maxRecentBlocks)
tmpChan := make(chan ChainsyncBlock, clientBlockBufferSize)
if s.subs == nil {
s.subs = make(map[ouroboros.ConnectionId]chan ChainsyncBlock)
}
Expand Down