Remove ProcessUtil and bump Gapotchenko.FX version #891
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -219,7 +219,7 @@ public sealed class Gw2InstanceIntegration : ServiceModule<GameIntegrationServic | |||
| } | |||
|
|
|||
| try { | |||
| this.CommandLine = newProcess.GetCommandLine(); | |||
| this.CommandLine = newProcess.ReadArguments(); | |||
| } catch (Win32Exception e) { | |||
There was a problem hiding this comment.
I am curious about what exception gets thrown here if ReadArguments() fails. I'll review the lib to double-check.
There was a problem hiding this comment.
Yeah, reviewing the source for Gapotchenko.FX.Diagnostics.Process it looks like there are a couple of possible outcomes. All are ultimately probably equally unrecoverable as far as I can tell. Could we change the catch to just catch on Exception and slightly revise the logger line message?
| @@ -219,7 +219,7 @@ public sealed class Gw2InstanceIntegration : ServiceModule<GameIntegrationServic | |||
| } | |||
|
|
|||
| try { | |||
| this.CommandLine = newProcess.GetCommandLine(); | |||
| this.CommandLine = newProcess.ReadArguments(); | |||
| } catch (Win32Exception e) { | |||
There was a problem hiding this comment.
Yeah, reviewing the source for Gapotchenko.FX.Diagnostics.Process it looks like there are a couple of possible outcomes. All are ultimately probably equally unrecoverable as far as I can tell. Could we change the catch to just catch on Exception and slightly revise the logger line message?
|
Sorry, I realize updating the branch from my testing is going to make it annoying to commit any changes. I suppose the online GitHub editor might make that easier, though. |
|
Discussion Reference
Breaking change: no
Minor cleanup to remove ProcessUtil and replace it with functionality built in to gapotchenko.fx