Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Project Not Visible Across Multiple Browsers #103

Closed
itailiors opened this issue Jun 7, 2024 · 4 comments · Fixed by #136
Closed

Created Project Not Visible Across Multiple Browsers #103

itailiors opened this issue Jun 7, 2024 · 4 comments · Fixed by #136

Comments

@itailiors
Copy link
Collaborator

When a user is connected on two different browsers and creates a project in one of them, the project is not visible in the other browser.
(Because of the way the scan in founder works that it only scans once)

Steps to Reproduce:

Be on 'x' wallet on Browser A.
Be on 'x' wallet on Browser B.
Create a new Angor project on Browser A.

p.s If it is the first project created by the user, it is possible that it will work as expected and be visible in both browsers.

@dangershony
Copy link
Member

Was this issues fixed in this commit? #101
@DavidGershony

@itailiors
Copy link
Collaborator Author

@dangershony @DavidGershony

I think we can close this issue if when we decide on the following:

For example, if someone has two active instances of Angor and creates a project on instance A, should they see it on instance B?
We can address this in two ways:

  1. Add logic to scan founder projects that deletes the current data and derives from the start.
  2. Require the user to wipe the data and recover the wallet.

I believe the first approach is more correct. If you agree, I can implement it.

@dangershony
Copy link
Member

I believe after Davids recent changes this is not the case anymore

@itailiors
Copy link
Collaborator Author

I believe after Davids recent changes this is not the case anymore

david's change was so the first load works, but we fetch only once now,
for example if you go now to the founder page you can see that the scan button isn't there because we already fetched.

and this problem we can solve with 1/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants