Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for issue 103 and 132 #136

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Conversation

itailiors
Copy link
Collaborator

Implement Rescan Functionality with Data Clearing for Founder Projects #103
And fix for invest page time and functionality #132
(@dangershony or @DavidGershony there's a TODO comment because i wasn't sure what is expected,
"//TODO: what should the order be here? if an investor has a signed trx that he has not invested yet, and the project has started, could he invest?" "

also i think there is another case of someone requesting to invest, and the founder hasn't signed until after the start date

@itailiors itailiors linked an issue Aug 16, 2024 that may be closed by this pull request
@itailiors
Copy link
Collaborator Author

also added #137 small fix

@dangershony
Copy link
Member

if an investor has a signed trx that he has not invested yet, and the project has started, could he invest?"

I think yes we should allow, perhaps we could displa a warning and add a limitation that if stage 1 has passed then no possibility to invest anymore.

@miwahn what do you think?

@dangershony
Copy link
Member

@DavidGershony this is for you to review

@itailiors
Copy link
Collaborator Author

#132 is still TBD right now it is "disabled" from the view page,
but if you change the URL you can still invest (and there is nothing else restricted)

image

@@ -111,15 +106,16 @@ else
{
scanningForProjects = true;

// Clear the existing projects before rescan
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we clear the data we already have?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree I will remove this lines

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dangershony @DavidGershony I added this because of the rescan feature,
now if you rescan there are duplicates.

maybe theres a better solution instead of deleting, to just add the ones that are different (we will also need to add logic for the same project being changed on another client)

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depending on your answer, i'll open a PR with the according fix

@dangershony dangershony marked this pull request as ready for review October 15, 2024 18:12
@dangershony dangershony merged commit 8b908d9 into main Oct 15, 2024
3 checks passed
@dangershony dangershony deleted the invest_time_fix_and_founder_scan branch October 15, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants