-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for issue 103 and 132 #136
Conversation
also added #137 small fix |
I think yes we should allow, perhaps we could displa a warning and add a limitation that if stage 1 has passed then no possibility to invest anymore. @miwahn what do you think? |
@DavidGershony this is for you to review |
# Conflicts: # src/Angor/Client/Pages/Invest.razor
#132 is still TBD right now it is "disabled" from the view page, |
src/Angor/Client/Pages/Founder.razor
Outdated
@@ -111,15 +106,16 @@ else | |||
{ | |||
scanningForProjects = true; | |||
|
|||
// Clear the existing projects before rescan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we clear the data we already have?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree I will remove this lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dangershony @DavidGershony I added this because of the rescan feature,
now if you rescan there are duplicates.
maybe theres a better solution instead of deleting, to just add the ones that are different (we will also need to add logic for the same project being changed on another client)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depending on your answer, i'll open a PR with the according fix
Implement Rescan Functionality with Data Clearing for Founder Projects #103
And fix for invest page time and functionality #132
(@dangershony or @DavidGershony there's a TODO comment because i wasn't sure what is expected,
"//TODO: what should the order be here? if an investor has a signed trx that he has not invested yet, and the project has started, could he invest?" "
also i think there is another case of someone requesting to invest, and the founder hasn't signed until after the start date