Fix a nostr subscription registration bug #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… subscription class
| @@ -117,7 +117,7 @@ public bool EoseEventReceivedOnAllRelays(string subscription) | |||
| public void MonitoringEoseReceivedOnSubscription(string subscription) | |||
| { | |||
| _logger.LogInformation($"Started monitoring subscription {subscription}"); | |||
| _eoseCalledOnSubscriptionClients.Add(subscription, new List<string>()); | |||
| _eoseCalledOnSubscriptionClients.TryAdd(subscription, new List<string>()); | |||
There was a problem hiding this comment.
Better to add a boolean returned from the method and check it in the caller so we can identify where the duplication is from
There was a problem hiding this comment.
So you mean a return TryAdd(... ?
There was a problem hiding this comment.
Instead I logged a warning is this good enough?
this was called from RelaySubscriptionsHandling.TryAddEoseAction
There was a problem hiding this comment.
Return the boolean and we can handle it from the caller
There was a problem hiding this comment.
Handle how? log it at the caller instead?
There was a problem hiding this comment.
Yes, that way we can tell where the duplication happens and why
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the dictionary _eoseCalledOnSubscriptionClients before adding a subscription class
I am not sure this is the correct fix because it might mean that we are not disposing of a subscription correctly
note this error returns until I refresh the page