Add Wallet flow. Refine project Invest (stages). #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangershony
reviewed
Dec 23, 2024
| public string Address { get; init; } | ||
| public decimal FeeRate { get; set; } | ||
| public decimal TotalFee { get; set; } | ||
| public decimal Amount { get; init; } |
There was a problem hiding this comment.
One thing that we have discuss earlier is that perhaps we should always represent amounts as sats and never as Bitcoin (decimal) only when we display we make the conversion
There was a problem hiding this comment.
Yes! It that that is quite reasonable. Sats is a coherent way to hold amounts. In the GUI, we could later convert it to our needs.
dangershony
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wallet Section
Invest Section (Browse project)
Misc