Skip to content

Add Wallet flow. Refine project Invest (stages). #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Dec 24, 2024

Conversation

SuperJMN
Copy link
Contributor

Wallet Section

  • It's now possible to complete a Send operation (test model)
  • Receive shows the receive address

Invest Section (Browse project)

  • Refinements (stage breakdown)

Misc

  • Model interfaces reside in their own project
  • Removed Browser project for now
  • Better componentalization

public string Address { get; init; }
public decimal FeeRate { get; set; }
public decimal TotalFee { get; set; }
public decimal Amount { get; init; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that we have discuss earlier is that perhaps we should always represent amounts as sats and never as Bitcoin (decimal) only when we display we make the conversion

Copy link
Contributor Author

@SuperJMN SuperJMN Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! It that that is quite reasonable. Sats is a coherent way to hold amounts. In the GUI, we could later convert it to our needs.

@dangershony dangershony merged commit 9d033c8 into block-core:main Dec 24, 2024
3 checks passed
@SuperJMN SuperJMN deleted the wallet branch December 27, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants