Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Tasks in Postgre-BlockRewindOperation #218

Open
wants to merge 1 commit into
base: Adding-postgre-sql-support
Choose a base branch
from
Open

Fixed Tasks in Postgre-BlockRewindOperation #218

wants to merge 1 commit into from

Conversation

theDRB123
Copy link
Contributor

Removed unnecessary Task.Run from Postgres-BlockRewindOperations

sondreb
sondreb approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@sondreb sondreb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I presume that it's not needed since the ExecuteDeleteAsync() will be a separate task executed in the Task.WhenAll?

@theDRB123
Copy link
Contributor Author

yes, ExecuteDeleteAsync() returns a task itself

@DavidGershony DavidGershony self-requested a review August 23, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sondreb sondreb sondreb approved these changes

@DavidGershony DavidGershony Awaiting requested review from DavidGershony

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theDRB123 @sondreb