Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 1 addition & 5 deletions src/agents/claude.rs
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,7 @@ impl AgentRuleGenerator for ClaudeGenerator {
if output_file.exists() || output_file.is_symlink() {
fs::remove_file(&output_file)?;
}

// Only clean skills if in skills mode
if self.skills_mode {
claude_skills::remove_generated_skills(current_dir)?;
}
claude_skills::remove_generated_skills(current_dir)?;

Ok(())
}
Expand Down
30 changes: 29 additions & 1 deletion src/operations/claude_skills.rs
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,10 @@ pub fn check_skills_in_sync(
std::fs::read_dir(&skills_dir)?
.filter_map(Result::ok)
.filter(|entry| {
entry.path().is_dir()
let path = entry.path();
// Only count directories, not symlinks (symlinks are handled by ExternalSkillsGenerator)
path.is_dir()
&& !path.is_symlink()
&& entry
.file_name()
.to_str()
Expand Down Expand Up @@ -391,4 +394,29 @@ mod tests {
let result = check_skills_in_sync(&source_files, temp_dir.path()).unwrap();
assert!(!result);
}

#[test]
fn test_check_skills_in_sync_ignores_symlinks() {
let temp_dir = TempDir::new().unwrap();
let source_files = vec![create_test_source_file(
"optional", "Optional", false, "Content",
)];

create_skill_file(
temp_dir.path(),
"ai-rules-generated-optional",
&generate_skill_content("optional", "Optional", "optional"),
);

let skills_dir = temp_dir.path().join(CLAUDE_SKILLS_DIR);
let symlink_target = temp_dir.path().join("fake-skill");
std::fs::create_dir_all(&symlink_target).unwrap();
std::os::unix::fs::symlink(
&symlink_target,
skills_dir.join("ai-rules-generated-symlink"),
)
.unwrap();

assert!(check_skills_in_sync(&source_files, temp_dir.path()).unwrap());
}
}