chore: add -race to Go tests #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
alecthomas
force-pushed
the
aat/go-test-race
branch
from
f57e164 to
857c786
Compare
alecthomas
force-pushed
the
aat/go-test-race
branch
from
857c786 to
48ef00b
Compare
|
Filed #1368 |
alecthomas
commented
Apr 30, 2024
| @@ -1,5 +1,3 @@ | |||
| //go:build !integration | |||
There was a problem hiding this comment.
@matt2e I have integration added to my build tags so that I can edit integration tests with completion (which I recommend), and this negation breaks completion in these files. For the purposes of running the integration tests we can either just run these, or explicitly select just the tests in files with the integration tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@matt2e there's a race in TestHashRing that I tried to fix without success, to I've skipped it for now. Will file a ticket for you to followup.