Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow dev provisioner to increase topic partitions #4241

Merged
merged 1 commit into from
Jan 30, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion backend/provisioner/dev_provisioner.go
Original file line number Diff line number Diff line change
Expand Up @@ -226,14 +226,18 @@ func provisionTopic() InMemResourceProvisionerFn {
}
} else if topicMetas[0].Err != sarama.ErrNoError {
return nil, fmt.Errorf("failed to describe topic %q: %w", topicID, topicMetas[0].Err)
} else if len(topicMetas[0].Partitions) != partitions {
} else if len(topicMetas[0].Partitions) > partitions {
var plural string
if len(topicMetas[0].Partitions) == 1 {
plural = "partition"
} else {
plural = "partitions"
}
logger.Warnf("Using existing topic %s with %d %s instead of %d", topicID, len(topicMetas[0].Partitions), plural, partitions)
} else if len(topicMetas[0].Partitions) < partitions {
if err := admin.CreatePartitions(topicID, int32(partitions), nil, false); err != nil {
return nil, fmt.Errorf("failed to increase partitions: %w", err)
}
}

return &schema.TopicRuntimeEvent{
Expand Down
Loading