feat(mcp): add MCP add/approve, permissions test, and improve skill remove#67
Merged
feat(mcp): add MCP add/approve, permissions test, and improve skill remove#67
Conversation
jom-sq
force-pushed
the
jom/feature-mcp-skill-management
branch
from
085d6b0 to
123be41
Compare
jom-sq
force-pushed
the
jom/feature-mcp-skill-management
branch
from
123be41 to
c122b7c
Compare
…emove - Add addMcp() and approveMcp() server functions wrapping amp mcp add/approve - Add testPermission() server function wrapping amp permissions test - Add /api/mcp-add, /api/mcp-approve, /api/permissions-test routes - Add mcp: add server and mcp: approve server commands to command palette - Add permissions: test command to command palette - Improve skill remove to fetch installed skills list before showing picker - Wire all new handlers through useModalActions and useAppModalHandlers - Two-step InputModal flow for MCP add (name → source) and permissions test (tool → cmd) Co-authored-by: Amp <amp@ampcode.com>
jom-sq
force-pushed
the
jom/feature-mcp-skill-management
branch
from
c122b7c to
e45d78f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 2: MCP & Skill Management UI
Implements the MCP & Skill Management UI from the feature parity plan.
Changes
Server (server/lib/skills.ts, server/routes/skills.ts):
addMcp(name, source)— wrapsamp mcp addapproveMcp(name)— wrapsamp mcp approvetestPermission(tool, cmd)— wrapsamp permissions test/api/mcp-add(POST),/api/mcp-approve(POST),/api/permissions-test(POST)Command Palette (src/commands/):
mcp: add server— two-step InputModal (name → source command)mcp: approve server— InputModal for server namepermissions: test— two-step InputModal (tool → command)Skill Remove improvement (src/hooks/useModalActions.ts):
/api/skills-summarybefore showing the remove dialogVerification
pnpm typecheck✅pnpm test✅ (242 tests pass)