Conversation
…g-and-drop - Change pendingImage (singular) to pendingImages (array, max 5) - Add drag-and-drop support on the input area - Handle multiple images in paste (clipboard) events - Save multiple images as artifacts with indexed filenames - Render multiple image thumbnails in chat messages - Reconstruct multiple images from thread history - Add drag-over visual indicator styling Co-authored-by: Amp <amp@ampcode.com>
- Extract readFileAsBase64 helper to eliminate 3x duplicated FileReader logic - Fix dragLeave flicker using enter/leave counter pattern (classic gotcha) - Add file size validation (MAX_IMAGE_SIZE_BYTES = 10MB) - Extract MAX_ATTACHED_IMAGES constant to shared/constants.ts - Fix lint error with proper Error rejection in FileReader promise Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for attaching multiple images (up to 5) to a message, with both paste and drag-and-drop support.
Changes
pendingImage(singular) →pendingImages(array, max 5) across the full stacktimestamp-0.png,timestamp-1.png), composes multi-image prompt for amp CLIFiles changed (11)
shared/websocket.ts,src/utils/parseMarkdown.ts,src/components/terminal/types.tssrc/components/terminal/useTerminalState.tssrc/components/terminal/TerminalInput.tsxsrc/components/terminal/Terminal.tsxsrc/components/terminal/useTerminalWebSocket.ts,server/websocket.tssrc/components/terminal/TerminalMessages.tsx,src/components/terminal/useTerminalMessages.tssrc/styles/terminal.cssTesting
pnpm checkpasses (format, lint, typecheck, build)