Conversation
ch4r10t33r
reviewed
Feb 11, 2026
|
|
||
| - name: Build library | ||
| run: zig build | ||
| - uses: actions/checkout@v4 |
Collaborator
There was a problem hiding this comment.
I had removed caching, one of my earlier PRs broke the cross compatibility test but that wasn't caught by the CI due to caching.
Collaborator
There was a problem hiding this comment.
Can you pls verify this with a couple of tests? I don't want to endup breaking cross language compatibility tests.
Contributor
Author
There was a problem hiding this comment.
we had a manual cache key that only invalidated on Cargo.lock changes, not source code changes. removed it so rust-cache@v2 uses its built-in logic (hashes both lock file and toml files).
ran the full cross-language test suite locally, all pass:
- 2^8: Rust↔Zig
- 2^32: Rust↔Zig
- Pre-generated keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernize CI workflow to align with zeam patterns.
Changes
NOTE: the failures are addressed in #99