Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: createVP accepts VCS instead of VC IDs #247

Merged
merged 10 commits into from
Jun 20, 2023

Conversation

andyv09
Copy link
Member

@andyv09 andyv09 commented Jun 17, 2023

  • Changed RPC method
  • Fixed RPC method request parameters type
  • Fixed dApp
  • Fixed combobox bug on dApp

This PR also fixes the following issues:

@Vid201 Vid201 linked an issue Jun 19, 2023 that may be closed by this pull request
martines3000
martines3000 previously approved these changes Jun 19, 2023
@martines3000
Copy link
Member

I will merge it after I merge some other things and create a new release.

@martines3000 martines3000 self-requested a review June 20, 2023 08:54
@martines3000 martines3000 merged commit 006f27c into develop Jun 20, 2023
27 checks passed
@martines3000 martines3000 deleted the feat/createVP-accepts-vcs branch June 20, 2023 08:55
tadejpodrekar pushed a commit that referenced this pull request Jun 20, 2023
* feat: change parameter to actual vcs

* fix: datastore combobox

* fix: linting problems

* fix: params tests

* fix: tests

* fix: linting errors

* fix: linting error

* chore: fix lint issues

---------

Co-authored-by: Martin Domajnko <domajnko.martin@gmail.com>
martines3000 added a commit that referenced this pull request Jun 20, 2023
* feat: change parameter to actual vcs

* fix: datastore combobox

* fix: linting problems

* fix: params tests

* fix: tests

* fix: linting errors

* fix: linting error

* chore: fix lint issues

---------

Co-authored-by: Martin Domajnko <domajnko.martin@gmail.com>
martines3000 added a commit that referenced this pull request Jun 20, 2023
* feat: change parameter to actual vcs

* fix: datastore combobox

* fix: linting problems

* fix: params tests

* fix: tests

* fix: linting errors

* fix: linting error

* chore: fix lint issues

---------

Co-authored-by: Martin Domajnko <domajnko.martin@gmail.com>
martines3000 added a commit that referenced this pull request Jun 20, 2023
* feat: change parameter to actual vcs

* fix: datastore combobox

* fix: linting problems

* fix: params tests

* fix: tests

* fix: linting errors

* fix: linting error

* chore: fix lint issues

---------

Co-authored-by: Martin Domajnko <domajnko.martin@gmail.com>
martines3000 added a commit that referenced this pull request Jun 20, 2023
* feat: change parameter to actual vcs

* fix: datastore combobox

* fix: linting problems

* fix: params tests

* fix: tests

* fix: linting errors

* fix: linting error

* chore: fix lint issues

---------

Co-authored-by: Martin Domajnko <domajnko.martin@gmail.com>
martines3000 added a commit that referenced this pull request Jun 20, 2023
* feat: change parameter to actual vcs

* fix: datastore combobox

* fix: linting problems

* fix: params tests

* fix: tests

* fix: linting errors

* fix: linting error

* chore: fix lint issues

---------

Co-authored-by: Martin Domajnko <domajnko.martin@gmail.com>
martines3000 added a commit that referenced this pull request Jun 20, 2023
* feat: change parameter to actual vcs

* fix: datastore combobox

* fix: linting problems

* fix: params tests

* fix: tests

* fix: linting errors

* fix: linting error

* chore: fix lint issues

---------

Co-authored-by: Martin Domajnko <domajnko.martin@gmail.com>
tadejpodrekar pushed a commit that referenced this pull request Jun 23, 2023
* feat: change parameter to actual vcs

* fix: datastore combobox

* fix: linting problems

* fix: params tests

* fix: tests

* fix: linting errors

* fix: linting error

* chore: fix lint issues

---------

Co-authored-by: Martin Domajnko <domajnko.martin@gmail.com>
tadejpodrekar pushed a commit that referenced this pull request Jun 23, 2023
* feat: change parameter to actual vcs

* fix: datastore combobox

* fix: linting problems

* fix: params tests

* fix: tests

* fix: linting errors

* fix: linting error

* chore: fix lint issues

---------

Co-authored-by: Martin Domajnko <domajnko.martin@gmail.com>
tadejpodrekar pushed a commit that referenced this pull request Jun 23, 2023
* feat: change parameter to actual vcs

* fix: datastore combobox

* fix: linting problems

* fix: params tests

* fix: tests

* fix: linting errors

* fix: linting error

* chore: fix lint issues

---------

Co-authored-by: Martin Domajnko <domajnko.martin@gmail.com>
@github-actions github-actions bot mentioned this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal]: RPC method createVP accepts VCs instead of ids
2 participants