Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/search bar swapping shelfs #176

Closed

Conversation

RafaDSan
Copy link
Collaborator

@RafaDSan RafaDSan commented Feb 27, 2024

closes #45

  • Create the proposed atom for SwappingShelfs.
  • Dark/Light mode
  • Check the style of the 3 States( DEFAULT, HOVER, PRESSING )

I've created the atom searchItemsShelf to be a search bar for the SwappingShelfs.tsx organism.

It has no function to search yet, it's just the model.

DARK MODE
image
image
image
image

LIGHT MODE
image
image
image
image

heronlancellot and others added 30 commits December 12, 2023 10:36
- add onest font in all {content]
- add onest font
- add dark/light mode
- change text-fonts and color switching light/dark
- add new layout like figma
- refactor all imports  & remove unused
- add header & icons changing with theme
- add prettier configuration
- format code with prettier
add empty cards in offer-sumary & nfts-list
- add initial structure of offers filter
- integrate the smart-contract - create-swap
- add abi
- refactor EmptyNftsCards
- add new types to use swap
- add expire-date using timestamp & selectedDate
- refactor frontend v1
- remove chains ids
- adjust the select time
- add create swap  n-n
- adjust design
- add MockERC721 && MockERC20 ABI
- add contract address
- add approveSwap encodedFunctionData
- update ConfirmSwapModal
- add getApproved function to know the approved selected tokens
- add validations to approved tokens
- refactor variable names
- add CONTRIBUTING.MD
- add CODE_OF_CONDUCT.md
- add SECURITY.md
FrancoAguzzi and others added 23 commits February 16, 2024 15:40
 feat: change env variable name for more clearance blockful-io#128
Copy link

vercel bot commented Feb 27, 2024

@RafaDSan is attempting to deploy a commit to the Shared Blockful's projects Team on Vercel.

A member of the Team first needs to authorize it.

);
};
fetchApprove();
}, [nftAuthUser, allSelectedNftsApproved]);

Check warning

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Warning

React Hook useEffect has missing dependencies: 'setAllSelectedNftsAreApproved' and 'setAuthedUserNftsApprovalStatus'. Either include them or remove the dependency array.
}

export const SwapContext = React.createContext<SwapContextProps>({
inputAddress: "",
validatedAddressToSwap: "",
validateAddressToSwap: (
_authedUser: EthereumAddress,
_inputEnsAddress: string | null | undefined
_inputEnsAddress: string | null | undefined,

Check failure

Code scanning / ESLint

Disallow unused variables Error

'_inputEnsAddress' is defined but never used.
@@ -41,6 +56,14 @@
nftInputUser: [],
destinyChain: SupportedNetworks.SEPOLIA,
setDestinyChain: () => {},
setTimeDate: () => {},

Check failure

Code scanning / ESLint

Disallow empty functions Error

Unexpected empty method 'setTimeDate'.
@@ -41,6 +56,14 @@
nftInputUser: [],
destinyChain: SupportedNetworks.SEPOLIA,
setDestinyChain: () => {},
setTimeDate: () => {},
timeDate: BigInt(1),
setAllSelectedNftsAreApproved: () => {},

Check failure

Code scanning / ESLint

Disallow empty functions Error

Unexpected empty method 'setAllSelectedNftsAreApproved'.
timeDate: BigInt(1),
setAllSelectedNftsAreApproved: () => {},
allSelectedNftsApproved: false,
setAuthedUserNftsApprovalStatus: () => {},

Check failure

Code scanning / ESLint

Disallow empty functions Error

Unexpected empty method 'setAuthedUserNftsApprovalStatus'.
export function SwapModalButton({
variant = ButtonVariant.DEFAULT,
label,
onClick = () => {},

Check failure

Code scanning / ESLint

Disallow empty functions Error

Unexpected empty arrow function.
if (currentSwapModalStep === SwapModalSteps.CREATING_SWAP) {
handleSwap();
}
}, [currentSwapModalStep]);

Check warning

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Warning

React Hook useEffect has a missing dependency: 'handleSwap'. Either include it or remove the dependency array.
if (!open) {
updateSwapStep(ButtonClickPossibilities.PREVIOUS_STEP);
}
}, [open]);

Check warning

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Warning

React Hook useEffect has a missing dependency: 'updateSwapStep'. Either include it or remove the dependency array.
);
};
fetchApprove();
}, [nftAuthUser, allSelectedNftsApproved]);

Check warning

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Warning

React Hook useEffect has missing dependencies: 'setAllSelectedNftsAreApproved', 'setAuthedUserNftsApprovalStatus', and 'updateSwapStep'. Either include them or remove the dependency array.
@@ -0,0 +1,46 @@
/* eslint-disable @typescript-eslint/no-var-requires */
require("dotenv").config();

Check failure

Code scanning / ESLint

Disallow `require` statements except in import statements Error

Require statement not part of import statement.
@RafaDSan RafaDSan closed this Feb 27, 2024
@RafaDSan RafaDSan deleted the feat/search-bar-swappingShelfs branch February 27, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: create a search-bar component for SwappingShelfs
7 participants