-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: accept offer #280
feat: accept offer #280
Conversation
- added the grid sizes to the card - added a new type called `isConfirmationModal` for confirmations when creating swaps in the swap station and when confirming accept swaps in swap offers. This boolean will define a single line of 5 squares - changed the laptop/desktop squares from 4 to 3. They were being overflowed/cutted from the frame - commented the entire placeholder code/logic - removed unnecessary Math when calculating emptySquaresCount - fixed overflows on offerSummary, hidden for X and auto for Y - fixed gap for mobile-s (was cutting out of the frame) - removed the scroll from the grids in all the offerSummary
fix: grid not showing in swap confirmation modal
- removed dashes from fill-rule and clip-rule Co-authored-by: frankind.eth <49823133+FrancoAguzzi@users.noreply.github.com>
…hain-svg Feat/network chain svg
- duplicated check on address Co-authored-by: frankind.eth <49823133+FrancoAguzzi@users.noreply.github.com>
Co-authored-by: frankind.eth <49823133+FrancoAguzzi@users.noreply.github.com>
…ddress-external-link Feat/display address external link
feat: fetch ponder data, display as tokenCard and further confirm the swap
Co-authored-by: frankind.eth <49823133+FrancoAguzzi@users.noreply.github.com>
Obs: Expiry not working yet
some console.logs
…-not-showing-up make the add Token button show up again
regarding the `usePonder`
the user is sgined in with the wallet. removed dev logs.
of strings
feat: Pagination with ponder and react query
@FrancoAguzzi is attempting to deploy a commit to the Shared Blockful's projects Team on Vercel. A member of the Team first needs to authorize it. |
setFailedLoadingImage(true); | ||
} | ||
} | ||
}, [avatarQueryStatus]); |
Check warning
Code scanning / ESLint
verifies the list of dependencies for Hooks like useEffect and similar Warning
@@ -98,6 +99,10 @@ | |||
checkForTokenApproval(token); | |||
}, []); | |||
|
|||
useEffect(() => { | |||
checkForTokenApproval(token); | |||
}, [chain, token, authenticatedUserAddress]); |
Check warning
Code scanning / ESLint
verifies the list of dependencies for Hooks like useEffect and similar Warning
@@ -35,7 +34,7 @@ | |||
setAuthenticatedUserTokensList([]); | |||
setSearchedUserTokensList([]); | |||
setInputAddress(""); | |||
}, [chain]); | |||
}, [chain, authenticatedUserAddress]); |
Check warning
Code scanning / ESLint
verifies the list of dependencies for Hooks like useEffect and similar Warning
}, [ | ||
address, | ||
isNetworkSupported, | ||
authenticatedUserAddress, | ||
validatedAddressToSwap, | ||
destinyChain, | ||
]); |
Check warning
Code scanning / ESLint
verifies the list of dependencies for Hooks like useEffect and similar Warning
|
||
useEffect(() => { | ||
updateCreateSwapApprovedTokensCount(0); | ||
}, [authenticatedUserTokensList]); |
Check warning
Code scanning / ESLint
verifies the list of dependencies for Hooks like useEffect and similar Warning
isFetchingNextPage: false, | ||
hasNextPage: false, | ||
isLoadingOffersQuery: false, | ||
acceptSwapOffer: () => {}, |
Check failure
Code scanning / ESLint
Disallow empty functions Error
acceptSwapOffer: () => {}, | ||
swapOfferToAccept: null, | ||
approvedTokensCount: 0, | ||
setApprovedTokensCount: () => {}, |
Check failure
Code scanning / ESLint
Disallow empty functions Error
} | ||
|
||
setDisplayableData(displayableData); | ||
}, [tokenData]); |
Check warning
Code scanning / ESLint
verifies the list of dependencies for Hooks like useEffect and similar Warning
|
||
useEffect(() => { | ||
offersQueries && processSwaps(); | ||
}, [offersQueries]); |
Check warning
Code scanning / ESLint
verifies the list of dependencies for Hooks like useEffect and similar Warning
@@ -88,9 +99,13 @@ | |||
} | |||
}; | |||
|
|||
useEffect(() => { | |||
clearSwapData(); | |||
}, []); |
Check warning
Code scanning / ESLint
verifies the list of dependencies for Hooks like useEffect and similar Warning
feat: swap confirmation modal for accepting swaps #269