Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added button to select another currency. #107

Closed
wants to merge 1 commit into from

Conversation

agarzon
Copy link

@agarzon agarzon commented Nov 24, 2020

Added button to select another currency. #94
Also fix the redirection the checkout page when order expires. #106

@blockonomics
Copy link
Owner

We don't need a new button to change currency. We need to fix the fundamental problem of the URL being incorrect. It is required to split the checkout screen into two URLS : currency selection and payment (as in wordpress)

The automatically fixes many problem of payment expiry, going back and other problem of page refresh not working

@agarzon
Copy link
Author

agarzon commented Nov 24, 2020

We don't need a new button to change currency. We need to fix the fundamental problem of the URL being incorrect. It is required to split the checkout screen into two URLS : currency selection and payment (as in wordpress)

Then the issue is different than the one I opened. Mine was only related with the lack of ability of change the currency once selected and this PR add that missing feature.

In the case of WP is different, there are 2 different pages with two different urls (used to be done years ago before the invention of single page applications).... of course we can do that.

And about the timing, it is just buggy code in javascript which works well in WP and not in WHMCS, (which is actually another different issue). It won't be fixed just because you refresh the page as in WP or having 2 different URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants