Cleanup bal (#4832)

bloomberg · Jul 16, 2024 · 6a3c2b1 · 6a3c2b1
1 parent f36c72c
commit 6a3c2b1
Show file tree

Hide file tree

Showing 58 changed files with 136 additions and 599 deletions.
diff --git a/groups/bal/balber/balber_berconstants.cpp b/groups/bal/balber/balber_berconstants.cpp
@@ -1,12 +1,4 @@
 // balber_berconstants.cpp                                            -*-C++-*-
-
-// ----------------------------------------------------------------------------
-//                                   NOTICE
-//
-// This component is not up to date with current BDE coding standards, and
-// should not be used as an example for new development.
-// ----------------------------------------------------------------------------
-
 #include <balber_berconstants.h>
 
 #include <bsls_ident.h>

diff --git a/groups/bal/balber/balber_berconstants.h b/groups/bal/balber/balber_berconstants.h
@@ -1,12 +1,4 @@
 // balber_berconstants.h                                              -*-C++-*-
-
-// ----------------------------------------------------------------------------
-//                                   NOTICE
-//
-// This component is not up to date with current BDE coding standards, and
-// should not be used as an example for new development.
-// ----------------------------------------------------------------------------
-
 #ifndef INCLUDED_BALBER_BERCONSTANTS
 #define INCLUDED_BALBER_BERCONSTANTS
 
@@ -27,6 +19,10 @@ BSLS_IDENT("$Id: $")
 //
 ///Usage
 ///-----
+// This section illustrates intended use of this component.
+//
+///Example 1: Basic Usage
+/// - - - - - - - - - - -
 // TBD
 
 #include <balscm_version.h>

diff --git a/groups/bal/balber/balber_berconstants.t.cpp b/groups/bal/balber/balber_berconstants.t.cpp
@@ -1,13 +1,4 @@
 // balber_berconstants.t.cpp                                          -*-C++-*-
-
-// ----------------------------------------------------------------------------
-//                                   NOTICE
-//
-// This component is not up to date with current BDE coding standards, and
-// should not be used as an example for new development.
-// ----------------------------------------------------------------------------
-
-
 #include <balber_berconstants.h>
 
 #include <bslim_testutil.h>
@@ -23,8 +14,7 @@ using namespace bsl;
 //                             TEST PLAN
 // ----------------------------------------------------------------------------
 //
-//
-
+// TBD
 // ----------------------------------------------------------------------------
 
 // ============================================================================

diff --git a/groups/bal/balber/balber_berdecoder.cpp b/groups/bal/balber/balber_berdecoder.cpp
@@ -1,12 +1,4 @@
 // balber_berdecoder.cpp                                              -*-C++-*-
-
-// ----------------------------------------------------------------------------
-//                                   NOTICE
-//
-// This component is not up to date with current BDE coding standards, and
-// should not be used as an example for new development.
-// ----------------------------------------------------------------------------
-
 #include <balber_berdecoder.h>
 
 #include <bsls_ident.h>

diff --git a/groups/bal/balber/balber_berdecoder.h b/groups/bal/balber/balber_berdecoder.h
@@ -1,12 +1,4 @@
 // balber_berdecoder.h                                                -*-C++-*-
-
-// ----------------------------------------------------------------------------
-//                                   NOTICE
-//
-// This component is not up to date with current BDE coding standards, and
-// should not be used as an example for new development.
-// ----------------------------------------------------------------------------
-
 #ifndef INCLUDED_BALBER_BERDECODER
 #define INCLUDED_BALBER_BERDECODER
 
@@ -105,21 +97,20 @@ BSLS_IDENT("$Id: $")
 #include <bdlat_typecategory.h>
 #include <bdlat_valuetypefunctions.h>
 
-#include <bslma_allocator.h>
-
-#include <bsl_string.h>
-
 #include <bdlb_variant.h>
 
 #include <bdlsb_memoutstreambuf.h>
 
+#include <bslma_allocator.h>
+
 #include <bsls_assert.h>
 #include <bsls_objectbuffer.h>
 #include <bsls_platform.h>
 #include <bsls_review.h>
 
 #include <bsl_istream.h>
 #include <bsl_ostream.h>
+#include <bsl_string.h>
 #include <bsl_vector.h>
 
 namespace BloombergLP {

diff --git a/groups/bal/balber/balber_berdecoder.t.cpp b/groups/bal/balber/balber_berdecoder.t.cpp
@@ -1,12 +1,4 @@
 // balber_berdecoder.t.cpp                                            -*-C++-*-
-
-// ----------------------------------------------------------------------------
-//                                   NOTICE
-//
-// This component is not up to date with current BDE coding standards, and
-// should not be used as an example for new development.
-// ----------------------------------------------------------------------------
-
 #include <balber_berdecoder.h>
 
 #include <balber_berencoder.h>        // for testing only
@@ -39,32 +31,29 @@
 #include <bdlsb_memoutstreambuf.h>      // for testing only
 #include <bdlsb_fixedmeminstreambuf.h>  // for testing only
 
+#include <bdlb_chartype.h>
+#include <bdlb_print.h>
+#include <bdlb_printmethods.h>
+
+#include <bdlt_date.h>
+#include <bdlt_datetime.h>
+#include <bdlt_prolepticdateimputil.h>
+#include <bdlt_time.h>
+
 #include <bslim_fuzzdataview.h>
 #include <bslim_fuzzutil.h>
 #include <bslim_printer.h>
 #include <bslim_testutil.h>
 
 #include <bslma_allocator.h>
+#include <bslma_testallocator.h>
+#include <bslma_testallocatormonitor.h>
 
 #include <bsls_objectbuffer.h>
 #include <bsls_review.h>
 #include <bsls_stopwatch.h>
 #include <bsls_types.h>
 
-#include <bdlt_date.h>
-#include <bdlt_datetime.h>
-#include <bdlt_prolepticdateimputil.h>
-#include <bdlt_time.h>
-
-#include <bdlb_chartype.h>
-#include <bdlb_print.h>
-#include <bdlb_printmethods.h>
-
-#include <bslim_testutil.h>
-
-#include <bslma_testallocator.h>
-#include <bslma_testallocatormonitor.h>
-
 #include <bsl_cstdlib.h>
 #include <bsl_cstring.h>
 #include <bsl_fstream.h>
@@ -73,7 +62,7 @@
 #include <bsl_iterator.h>
 
 using namespace BloombergLP;
-using namespace bsl;  // automatically added by script
+using namespace bsl;
 namespace test = BloombergLP::s_baltst;
 
 // ============================================================================

diff --git a/groups/bal/balber/balber_berdecoderoptions.cpp b/groups/bal/balber/balber_berdecoderoptions.cpp
@@ -1,27 +1,20 @@
 // balber_berdecoderoptions.cpp                                       -*-C++-*-
-
-// ----------------------------------------------------------------------------
-//                                   NOTICE
-//
-// This component is not up to date with current BDE coding standards, and
-// should not be used as an example for new development.
-// ----------------------------------------------------------------------------
-
 #include <balber_berdecoderoptions.h>
 
 #include <bsls_ident.h>
 BSLS_IDENT_RCSID(balber_berdecoderoptions_cpp,"$Id$ $CSID$")
 
 #include <bdlat_formattingmode.h>
 
-#include <bsls_assert.h>
 #include <bdlb_chartype.h>
 #include <bdlb_print.h>
 #include <bdlb_printmethods.h>
 #include <bdlb_string.h>
 
-#include <bsl_ostream.h>
+#include <bsls_assert.h>
+
 #include <bsl_iomanip.h>
+#include <bsl_ostream.h>
 
 namespace BloombergLP {
 
@@ -45,36 +38,36 @@ const bdlat_AttributeInfo balber::BerDecoderOptions::ATTRIBUTE_INFO_ARRAY[] = {
         "MaxDepth",                        // name
         sizeof("MaxDepth") - 1,            // name length
         "maximum recursion depth",         // annotation
-        bdlat_FormattingMode::e_DEC    // formatting mode
+        bdlat_FormattingMode::e_DEC        // formatting mode
     },
     {
         e_ATTRIBUTE_ID_SKIP_UNKNOWN_ELEMENTS,
         "SkipUnknownElements",             // name
         sizeof("SkipUnknownElements") - 1, // name length
         "Option to skip unknown elements", // annotation
-        bdlat_FormattingMode::e_TEXT   // formatting mode
+        bdlat_FormattingMode::e_TEXT       // formatting mode
     },
     {
         e_ATTRIBUTE_ID_TRACE_LEVEL,
         "TraceLevel",                      // name
         sizeof("TraceLevel") - 1,          // name length
         "trace (verbosity) level",         // annotation
-        bdlat_FormattingMode::e_DEC    // formatting mode
+        bdlat_FormattingMode::e_DEC        // formatting mode
     },
     {
         e_ATTRIBUTE_ID_MAX_SEQUENCE_SIZE,
         "MaxSequenceSize",                 // name
         sizeof("MaxSequenceSize") - 1,     // name length
         "maximum sequence size",           // annotation
-        bdlat_FormattingMode::e_DEC    // formatting mode
+        bdlat_FormattingMode::e_DEC        // formatting mode
     },
     {
         e_ATTRIBUTE_ID_DEFAULT_EMPTY_STRINGS,
         "DefaultEmptyStrings",             // name
         sizeof("DefaultEmptyStrings") - 1, // name length
         "Option to decode empty strings as their default values",
                                            // annotation
-        bdlat_FormattingMode::e_TEXT   // formatting mode
+        bdlat_FormattingMode::e_TEXT       // formatting mode
     }
 };
 

diff --git a/groups/bal/balber/balber_berdecoderoptions.h b/groups/bal/balber/balber_berdecoderoptions.h
@@ -1,12 +1,4 @@
 // balber_berdecoderoptions.h                                         -*-C++-*-
-
-// ----------------------------------------------------------------------------
-//                                   NOTICE
-//
-// This component is not up to date with current BDE coding standards, and
-// should not be used as an example for new development.
-// ----------------------------------------------------------------------------
-
 #ifndef INCLUDED_BALBER_BERDECODEROPTIONS
 #define INCLUDED_BALBER_BERDECODEROPTIONS
 
@@ -26,13 +18,13 @@ BSLS_IDENT("$Id: $")
 #include <bdlat_typetraits.h>
 #include <bdlat_valuetypefunctions.h>
 
+#include <bdlb_printmethods.h>
+
 #include <bsls_assert.h>
 
 #include <bslx_instreamfunctions.h>
 #include <bslx_outstreamfunctions.h>
 
-#include <bdlb_printmethods.h>
-
 #include <bsl_iosfwd.h>
 
 namespace BloombergLP {

diff --git a/groups/bal/balber/balber_berdecoderoptions.t.cpp b/groups/bal/balber/balber_berdecoderoptions.t.cpp
@@ -1,12 +1,4 @@
 // balber_berdecoderoptions.t.cpp                                     -*-C++-*-
-
-// ----------------------------------------------------------------------------
-//                                   NOTICE
-//
-// This component is not up to date with current BDE coding standards, and
-// should not be used as an example for new development.
-// ----------------------------------------------------------------------------
-
 #include <balber_berdecoderoptions.h>
 
 #include <bsls_ident.h>

diff --git a/groups/bal/balber/balber_berencoder.cpp b/groups/bal/balber/balber_berencoder.cpp
@@ -1,18 +1,11 @@
 // balber_berencoder.cpp                                              -*-C++-*-
-
-// ----------------------------------------------------------------------------
-//                                   NOTICE
-//
-// This component is not up to date with current BDE coding standards, and
-// should not be used as an example for new development.
-// ----------------------------------------------------------------------------
-
 #include <balber_berencoder.h>
 
 #include <bsls_ident.h>
 BSLS_IDENT_RCSID(balber_berencoder_cpp,"$Id$ $CSID$")
 
 #include <bdlat_formattingmode.h>
+
 #include <bslma_default.h>
 
 namespace BloombergLP {

diff --git a/groups/bal/balber/balber_berencoder.h b/groups/bal/balber/balber_berencoder.h
@@ -1,12 +1,4 @@
 // balber_berencoder.h                                                -*-C++-*-
-
-// ----------------------------------------------------------------------------
-//                                   NOTICE
-//
-// This component is not up to date with current BDE coding standards, and
-// should not be used as an example for new development.
-// ----------------------------------------------------------------------------
-
 #ifndef INCLUDED_BALBER_BERENCODER
 #define INCLUDED_BALBER_BERENCODER
 
@@ -183,19 +175,18 @@ BSLS_IDENT("$Id: $")
 #include <bdlat_typecategory.h>
 #include <bdlat_typename.h>
 
-#include <bslma_allocator.h>
-
-#include <bsl_string.h>
-
 #include <bdlsb_memoutstreambuf.h>
 
+#include <bslma_allocator.h>
+
+#include <bsls_assert.h>
 #include <bsls_objectbuffer.h>
 
 #include <bsl_ostream.h>
+#include <bsl_string.h>
 #include <bsl_vector.h>
 #include <bsl_typeinfo.h>
 
-#include <bsls_assert.h>
 
 namespace BloombergLP {
 namespace balber {

diff --git a/groups/bal/balber/balber_berencoder.t.cpp b/groups/bal/balber/balber_berencoder.t.cpp
@@ -1,14 +1,6 @@
 // balber_berencoder.t.cpp                                            -*-C++-*-
-
 #include <balber_berencoder.h>
 
-// ----------------------------------------------------------------------------
-//                                   NOTICE
-//
-// This component is not up to date with current BDE coding standards, and
-// should not be used as an example for new development.
-// ----------------------------------------------------------------------------
-
 #include <balber_berconstants.h>
 #include <balber_berutil.h>
 

diff --git a/groups/bal/balber/balber_berencoderoptions.t.cpp b/groups/bal/balber/balber_berencoderoptions.t.cpp
@@ -1,12 +1,4 @@
 // balber_berencoderoptions.t.cpp                                     -*-C++-*-
-
-// ----------------------------------------------------------------------------
-//                                   NOTICE
-//
-// This component is not up to date with current BDE coding standards, and
-// should not be used as an example for new development.
-// ----------------------------------------------------------------------------
-
 #include <balber_berencoderoptions.h>
 
 #include <bslim_testutil.h>

diff --git a/groups/bal/balber/balber_beruniversaltagnumber.cpp b/groups/bal/balber/balber_beruniversaltagnumber.cpp
@@ -1,12 +1,4 @@
 // balber_beruniversaltagnumber.cpp                                   -*-C++-*-
-
-// ----------------------------------------------------------------------------
-//                                   NOTICE
-//
-// This component is not up to date with current BDE coding standards, and
-// should not be used as an example for new development.
-// ----------------------------------------------------------------------------
-
 #include <balber_beruniversaltagnumber.h>
 
 #include <bsls_ident.h>