-
Notifications
You must be signed in to change notification settings - Fork 143
Feat[IT]: Support various broker binaries #633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jll63
requested changes
Feb 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks fine, just two grumbles.
4be4809
to
5180532
Compare
Signed-off-by: Dmitrii Petukhov <dpetukhov@bloomberg.net>
Signed-off-by: Dmitrii Petukhov <dpetukhov@bloomberg.net>
Signed-off-by: Dmitrii Petukhov <dpetukhov@bloomberg.net>
Signed-off-by: Dmitrii Petukhov <dpetukhov@bloomberg.net>
Signed-off-by: Dmitrii Petukhov <dpetukhov@bloomberg.net>
Signed-off-by: Dmitrii Petukhov <dpetukhov@bloomberg.net>
4fb1c97
to
17f566e
Compare
jll63
previously approved these changes
Mar 17, 2025
678098
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Implemented support for different versions of BMQ broker binaries in Integration tests.
Updated paths resolution mechanism which takes into account broker name. For example if cluster fixture contains several nodes (e.g. east1, east2, west1, west2) paths to the broker binary can be specified via the following env vars:
If the path is not specified for a particular node (via env var), the default path is used.
Testing performed
Example how to run new IT test suite:
BLAZINGMQ_BROKER_EAST1=../bmq41/bmqbrkr.tsk BLAZINGMQ_BROKER_WEST2=../bmq42/bmqbrkr.tsk ./src/integration-tests/run-tests multi -s