Skip to content

Feat[IT]: Support various broker binaries #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 18, 2025

Conversation

bbpetukhov
Copy link
Collaborator

@bbpetukhov bbpetukhov commented Feb 26, 2025

Describe your changes
Implemented support for different versions of BMQ broker binaries in Integration tests.

Updated paths resolution mechanism which takes into account broker name. For example if cluster fixture contains several nodes (e.g. east1, east2, west1, west2) paths to the broker binary can be specified via the following env vars:

  • BLAZINGMQ_BROKER_EAST1 for node "east1"
  • BLAZINGMQ_BROKER_EAST2 for node "east2"
  • BLAZINGMQ_BROKER_WEST1 for node "west1"
  • BLAZINGMQ_BROKER_WEST2 for node "west2"

If the path is not specified for a particular node (via env var), the default path is used.

Testing performed

  • Integration tests with mark "multi" passed

Example how to run new IT test suite:
BLAZINGMQ_BROKER_EAST1=../bmq41/bmqbrkr.tsk BLAZINGMQ_BROKER_WEST2=../bmq42/bmqbrkr.tsk ./src/integration-tests/run-tests multi -s

Copy link
Collaborator

@jll63 jll63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks fine, just two grumbles.

@bbpetukhov bbpetukhov changed the title Feat[IT]: Support various broker binaries in Feat[IT]: Support various broker binaries Mar 5, 2025
@bbpetukhov bbpetukhov force-pushed the version-upgrade-tests branch 2 times, most recently from 4be4809 to 5180532 Compare March 10, 2025 15:22
Signed-off-by: Dmitrii Petukhov <dpetukhov@bloomberg.net>
Signed-off-by: Dmitrii Petukhov <dpetukhov@bloomberg.net>
Signed-off-by: Dmitrii Petukhov <dpetukhov@bloomberg.net>
Signed-off-by: Dmitrii Petukhov <dpetukhov@bloomberg.net>
Signed-off-by: Dmitrii Petukhov <dpetukhov@bloomberg.net>
Signed-off-by: Dmitrii Petukhov <dpetukhov@bloomberg.net>
@bbpetukhov bbpetukhov force-pushed the version-upgrade-tests branch from 4fb1c97 to 17f566e Compare March 16, 2025 15:10
@bbpetukhov bbpetukhov marked this pull request as ready for review March 16, 2025 15:17
@bbpetukhov bbpetukhov requested a review from a team as a code owner March 16, 2025 15:17
jll63
jll63 previously approved these changes Mar 17, 2025
Signed-off-by: Dmitrii Petukhov <dpetukhov@bloomberg.net>
@kaikulimu kaikulimu merged commit 59be58b into bloomberg:main Mar 18, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants