Display hostName other than podName #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j4ckstraw
force-pushed
the
feat/show-nodename
branch
from
1209206 to
08b1a37
Compare
Signed-off-by: wanglijie6 <wanglijie6@xiaomi.com>
j4ckstraw
force-pushed
the
feat/show-nodename
branch
from
08b1a37 to
588c1a0
Compare
|
Hi @j4ckstraw thanks for the PR! How would you feel about making your behaviour change hide behind an extra command line flag, that's defaulting to false for backwards compatibility? I see how this might be useful, but we don't want to be break existing users. |
|
OK, I will file the patch later. |
Add GoldpingerConfig.DisplayNodeName to control UI display, default is `false`, which means to display podName Signed-off-by: wanglijie6 <wanglijie6@xiaomi.com>
j4ckstraw
force-pushed
the
feat/show-nodename
branch
from
2917de6 to
7609a3a
Compare
|
fix #99 |
|
Hi, how can I use the env "DISPLAY_NODENAME" in my daemonset yaml file? This was my trying, but not working: I'd like to have the view in UI goldpinger the node name instead pod name. |
|
@wesleyoliveiraleite have you tried the following? Because the parameter is a boolean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #
Describe your changes
I changed
pod.Nametop.Spec.NodeName, so we can see the nodename other than podname in the UI.Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.
Additional context
Add any other context about your contribution here.
goldpinger is deployed by daemonset, so nodename is better than podname.