-
Notifications
You must be signed in to change notification settings - Fork 41
Choose appropriate visualizations LS_DS_122_Choose_appropriate_visualization #27
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job Mark, on #2 I noticed you've yet to complete this. Let me know if any questions arise. Keep up the good work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sprint Challenge Code Review
Week 2 - Storytelling with Data
Part 0 — Run this starter code
Part 1 — What's the breakdown of guests’ occupations per year?
Code review
What went well:
-I like your use of the shape function and head before using crosstab:
<df.head()>
``` ```
What could be better:
- You did great here, all I can say is look into crosstab more and build!(great job turning them into percentages):
``` ```
Part 2 — Recreate this explanatory visualization:
Code review
What went well:
- I like the use of seaborn and plt in the solution!:
<ct.columns>
plt.plot(t['Government and Politics'],c='r')
plt.plot(t['Media'], c='purple')
_What could be better:_
- I'm impressed with the X and Y of your data but it could be shortented like so:
<insert plt.text(x=1998, y=1.1, s="Who Got To Be On 'The Daily Show'?", fontweight='bold')
plt.text(x=1998, y=1.0, s='Occupation of guests, by year');>
Part 3 — Who were the top 10 guests on The Daily Show?
Code review
What went well:
- I like your use of colors and great visualation!:
<plt.barh(f10.index, f10.values,color=['black', 'red', 'green', 'blue', 'cyan', 'purple', 'orange', 'grey', 'magenta', 'yellow' ])
>
- Great job taking the top 10 in one line: ``` ```
_What could be better:_
- Overall great job! this could be a one liner though!
<df.Guest.value_counts().head(10).plot.bar();>
Mark Oliver