Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce updates to weekly and remove black #43

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

blooop
Copy link
Owner

@blooop blooop commented Jan 2, 2025

Summary by Sourcery

Update the dependabot configuration to check for updates monthly instead of weekly and remove black from the dev-dependencies group.

Enhancements:

  • Remove black from the development dependencies group.

CI:

  • Update the dependency update schedule from weekly to monthly.

Copy link
Contributor

sourcery-ai bot commented Jan 2, 2025

Reviewer's Guide by Sourcery

This pull request modifies the dependabot configuration to reduce the frequency of updates for pip dependencies from weekly to monthly and removes the black formatter from the dev-dependencies group.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Reduce update frequency
  • Changed the schedule.interval from weekly to monthly for the pip package ecosystem
.github/dependabot.yml
Remove black from dev-dependencies
  • Removed black from the dev-dependencies group's patterns
.github/dependabot.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @blooop - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please document the rationale for reducing update frequency to monthly. While this may reduce PR noise, it could delay security patches.
  • What's the reasoning behind removing black from the grouped dependencies? Is it being removed from the project or handled separately?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@blooop blooop merged commit 875bd66 into main Jan 2, 2025
7 checks passed
@blooop blooop deleted the feature/update_dependabot branch January 2, 2025 20:44
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.88%. Comparing base (0205f63) to head (8b135c7).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   25.88%   25.88%           
=======================================
  Files           1        1           
  Lines          85       85           
=======================================
  Hits           22       22           
  Misses         63       63           

Impacted file tree graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant