Skip to content

Commit

Permalink
Updated coding standard and fixd errors
Browse files Browse the repository at this point in the history
  • Loading branch information
blue32a committed Apr 10, 2021
1 parent 6d5e0cc commit 5ace325
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 16 deletions.
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"illuminate/support": "^6.0|^7.0"
},
"require-dev": {
"blue32a/php-coding-standard": "v0.1.0-alpha",
"blue32a/php-coding-standard": "v0.3.0-alpha",
"mockery/mockery": "^1.3",
"php-parallel-lint/php-parallel-lint": "^1.3",
"phpunit/phpunit": "^8.5"
Expand Down
9 changes: 0 additions & 9 deletions src/ServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ class ServiceProvider extends BaseServiceProvider
*/
public function register()
{
//
}

/**
Expand All @@ -34,10 +33,6 @@ public function boot()
});
}

/**
* @param array $config
* @return AzureBlobStorageAdapter
*/
protected function createAdapter(array $config): AzureBlobStorageAdapter
{
$connectionStr = $this->createConnectionString($config);
Expand All @@ -49,10 +44,6 @@ protected function createAdapter(array $config): AzureBlobStorageAdapter
return $adapter;
}

/**
* @param array $config
* @return string
*/
protected function createConnectionString(array $config): string
{
$connectionStr = sprintf(
Expand Down
10 changes: 4 additions & 6 deletions tests/ServiceProviderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ protected function createTargetReflection()
/**
* @test
*/
public function testBoot()
public function testBoot(): void
{
$storageSpy = Storage::spy();

Expand All @@ -49,12 +49,11 @@ public function testBoot()
}

/**
* @test
* @runInSeparateProcess
* @preserveGlobalState disabled
* @return void
* @test
*/
public function testCreateAdapter()
public function testCreateAdapter(): void
{
$publicEndpoint = 'https://storage.example.com';
$config = [
Expand Down Expand Up @@ -100,9 +99,8 @@ protected function createBlobRestProxyAliasMock()

/**
* @test
* @return void
*/
public function testCreateConnectionString()
public function testCreateConnectionString(): void
{
$targetRef = $this->createTargetReflection();

Expand Down

0 comments on commit 5ace325

Please sign in to comment.