MacOS support #191
Merged
MacOS support #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
this ensures the app will properly dispose the player resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Mac OS. Fixes #112
media_kitrequirements (https://github.com/media-kit/media-kit#macos)app_linksrequirements (https://pub.dev/packages/app_links/versions/3.5.0-beta.2#getting-started)window_managerrequirements (https://pub.dev/packages/window_manager#macos)The core app design is not supposed to change, but it must respect some of apple's guidelines.
The "desktop buttons" are different on macOS and must be adapted.
The position of primary/secondary buttons on a list tile needs to be reconsidered.
The platform menu bar should also be used and preferred over the current navigation approach.
Usage of cupertino widgets wherever possible, such as
CupertinoActivityIndicator, date pickers, and others.