Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly zoom in all matrix sizes #227

Merged
merged 9 commits into from
Mar 23, 2024
Merged

Conversation

bdlukaa
Copy link
Collaborator

@bdlukaa bdlukaa commented Mar 23, 2024

This PR fixes an issue that would not let the software zoom work properly on matrix sizes other than 4x4.

  • Software zoom now works in any matrix size;
  • Zooming in and out is now supported on the web and on embedded devices;
  • Correctly apply the local matrix size when edited.

Additionally, some updates to the settings were made:

  • Implemented a value overrider. This is useful when a property needs to have a forced value at a specific platform or due to an environment limitation. It is used to ensure macOS, web and embedded will always use software zoom;
  • Show an "Are you sure?" dialog when the user tries to restore all the settings options to the default. It is also marked as a destructive action;
  • Implemented "choose download location for each download" option. When enabled, the user will be prompted to choose the download location for each download.

@bdlukaa bdlukaa merged commit d67b08c into bluecherrydvr:main Mar 23, 2024
8 of 9 checks passed
@bdlukaa bdlukaa deleted the zoom-fix branch March 23, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant