Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfixes #273

Merged
merged 5 commits into from
Oct 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions lib/api/api.dart
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
*/

import 'dart:convert';
import 'dart:io';

import 'package:bluecherry_client/api/api_helpers.dart';
import 'package:bluecherry_client/models/device.dart';
Expand Down Expand Up @@ -52,6 +53,8 @@ class API {
}
}

static String get cookieHeader => HttpHeaders.cookieHeader;

/// Checks details of a [server] entered by the user.
/// If the attributes present in [Server] are correct, then the
/// returned object will have [Server.serverUUID] & [Server.cookie]
Expand Down Expand Up @@ -139,7 +142,7 @@ class API {
},
),
headers: {
if (server.cookie != null) 'Cookie': server.cookie!,
if (server.cookie != null) API.cookieHeader: server.cookie!,
},
);
// debugPrint(response.body);
Expand Down Expand Up @@ -207,7 +210,7 @@ class API {
'/mobile-app-config.json',
),
headers: {
'Cookie': server.cookie!,
if (server.cookie != null) API.cookieHeader: server.cookie!,
},
);
final body = jsonDecode(response.body);
Expand Down Expand Up @@ -235,8 +238,8 @@ class API {
final response = await client.post(
Uri.parse('${uri!}store-token'),
headers: {
'Cookie': server.cookie!,
'Content-Type': 'application/json',
API.cookieHeader: server.cookie!,
HttpHeaders.contentTypeHeader: 'application/json',
},
body: jsonEncode(
{
Expand Down Expand Up @@ -279,7 +282,7 @@ class API {
final response = await client.post(
Uri.parse('${uri!}remove-token'),
headers: {
'Cookie': server.cookie!,
API.cookieHeader: server.cookie!,
'Content-Type': 'application/json',
},
body: jsonEncode(
Expand Down
8 changes: 6 additions & 2 deletions lib/api/events.dart
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,12 @@ extension EventsExtension on API {
if (deviceId != null) 'device_id': '$deviceId',
},
);
final response =
await API.client.get(uri, headers: {'Cookie': server.cookie!});
final response = await API.client.get(
uri,
headers: {
if (server.cookie != null) API.cookieHeader: server.cookie!,
},
);

var events = const Iterable<Event>.empty();

Expand Down
8 changes: 5 additions & 3 deletions lib/api/ptz.dart
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

import 'dart:io';

import 'package:bluecherry_client/api/api.dart';
import 'package:bluecherry_client/models/device.dart';
import 'package:flutter/widgets.dart';
Expand Down Expand Up @@ -116,7 +118,7 @@ extension PtzApiExtension on API {
url,
headers: {
'Content-Type': 'application/x-www-form-urlencoded',
'Cookie': server.cookie!,
if (server.cookie != null) API.cookieHeader: server.cookie!,
},
);

Expand Down Expand Up @@ -158,8 +160,8 @@ extension PtzApiExtension on API {
final response = await API.client.get(
url,
headers: {
'Content-Type': 'application/x-www-form-urlencoded',
'Cookie': server.cookie!,
HttpHeaders.contentTypeHeader: 'application/x-www-form-urlencoded',
if (server.cookie != null) API.cookieHeader: server.cookie!,
},
);

Expand Down
2 changes: 1 addition & 1 deletion lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -153,11 +153,11 @@ Future<void> main(List<String> args) async {
// wait time at the splash screen
// settings provider needs to be initalized alone
await SettingsProvider.ensureInitialized();
await ServersProvider.ensureInitialized();
await Future.wait([
DownloadsManager.ensureInitialized(),
MobileViewProvider.ensureInitialized(),
DesktopViewProvider.ensureInitialized(),
ServersProvider.ensureInitialized(),
UpdateManager.ensureInitialized(),
EventsProvider.ensureInitialized(),
]);
Expand Down
5 changes: 4 additions & 1 deletion lib/models/device.dart
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,10 @@ class Device {
);

try {
var response = await API.client.get(uri);
var response = await API.client.get(uri, headers: {
if (device.server.cookie != null)
API.cookieHeader: device.server.cookie!,
});

if (response.statusCode == 200) {
var ret = json.decode(response.body) as Map;
Expand Down
14 changes: 14 additions & 0 deletions lib/providers/events_provider.dart
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import 'package:bluecherry_client/providers/app_provider_interface.dart';
import 'package:bluecherry_client/providers/server_provider.dart';
import 'package:bluecherry_client/screens/events_browser/filter.dart';
import 'package:bluecherry_client/utils/constants.dart';
import 'package:bluecherry_client/utils/extensions.dart';
import 'package:bluecherry_client/utils/logging.dart';
import 'package:bluecherry_client/utils/storage.dart';
import 'package:flutter/foundation.dart';
Expand Down Expand Up @@ -133,6 +134,19 @@ class EventsProvider extends UnityProvider {

selectedDevices =
List<String>.from(data['selectedDevices'] as List).toSet();
selectedDevices.removeWhere((device) {
final server = ServersProvider.instance.servers.firstWhereOrNull(
(server) => server.devices.any((d) => d.streamURL == device),
);
return server == null ||
!server.devices.any((d) {
if (d.streamURL == device) {
return d.status;
} else {
return false;
}
});
});

super.restore(notifyListeners: notifyListeners);
}
Expand Down
2 changes: 1 addition & 1 deletion lib/providers/settings_provider.dart
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ class SettingsProvider extends UnityProvider {
};
}

// TODO(bdlukaa): remove this in future releases
// TODO(bdlukaa): Remove this migration in future releases
var _hasMigratedTimezone = false;
late final kConvertTimeToLocalTimezone = _SettingsOption<bool>(
def: true,
Expand Down
15 changes: 7 additions & 8 deletions lib/utils/logging.dart
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,12 @@ void handleError(
writeErrorToFile(error, stackTrace, context);
}

Future<File> getLogFile() async {
Future<File?> getLogFile() async {
try {
return File(path.join(supportDir.path, 'logs.txt'));
} catch (e) {
debugPrint('Error getting log file: $e');
return File('./logs.txt');
// debugPrint('Error getting log file: $e');
return null;
}
}

Expand All @@ -67,9 +67,8 @@ Future<void> writeErrorToFile(
'[$time]Stack trace: $stackTrace';

final file = await getLogFile();

await file.writeAsString(errorLog, mode: FileMode.append);
Logger.root.log(Level.INFO, 'Wrote log file to "${file.path}"');
await file?.writeAsString(errorLog, mode: FileMode.append);
Logger.root.log(Level.INFO, 'Wrote log file to "${file?.path}"');
Logger.root.log(Level.SEVERE, errorLog);
}

Expand All @@ -78,8 +77,8 @@ Future<void> writeLogToFile(String text, {bool print = false}) async {
final time = DateTime.now().toIso8601String();
final file = await getLogFile();

await file.writeAsString('\n[$time] $text', mode: FileMode.append);
if (print) Logger.root.log(Level.INFO, 'Wrote log file to "${file.path}"');
await file?.writeAsString('\n[$time] $text', mode: FileMode.append);
if (print) Logger.root.log(Level.INFO, 'Wrote log file to "${file?.path}"');
}
if (print) debugPrint(text);
}
Expand Down
18 changes: 15 additions & 3 deletions lib/utils/video_player.dart
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

import 'dart:async';

import 'package:bluecherry_client/api/api.dart';
import 'package:bluecherry_client/models/device.dart';
import 'package:bluecherry_client/models/event.dart';
import 'package:bluecherry_client/providers/settings_provider.dart';
Expand Down Expand Up @@ -100,7 +101,10 @@ class UnityPlayers with ChangeNotifier {
};
debugPrint('Initializing $source');
controller.fallbackUrl = fallback;
await controller.setDataSource(source);
await controller.setDataSource(source, headers: {
if (device.server.cookie != null)
API.cookieHeader: device.server.cookie!,
});

_reloadable.add(source);
}
Expand Down Expand Up @@ -155,12 +159,20 @@ class UnityPlayers with ChangeNotifier {
softwareZoom: settings().kSoftwareZooming.value,
onLog: (message) {
logStreamToFile(
event.mediaURL?.toString() ?? 'Event ${event.title} (${event.id})',
event.mediaURL == null
? 'Event ${event.title} (${event.id})'
: event.mediaPath,
message,
);
},
)
..setDataSource(event.mediaPath.toString())
..setDataSource(
event.mediaPath,
headers: {
if (event.server.cookie != null)
API.cookieHeader: event.server.cookie!,
},
)
..setVolume(1.0)
..setSpeed(1.0);

Expand Down
1 change: 0 additions & 1 deletion linux/flutter/generated_plugins.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ list(APPEND FLUTTER_PLUGIN_LIST
)

list(APPEND FLUTTER_FFI_PLUGIN_LIST
media_kit_native_event_loop
)

set(PLUGIN_BUNDLED_LIBRARIES)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,11 @@ class UnityVideoPlayerFlutter extends UnityVideoPlayer {
_videoStream.stream.map((value) => value.isPlaying);

@override
Future<void> setDataSource(String url, {bool autoPlay = true}) async {
Future<void> setDataSource(
String url, {
bool autoPlay = true,
Map<String, String>? headers,
}) async {
if (url == dataSource) return Future.value();

if (player != null) {
Expand All @@ -180,7 +184,10 @@ class UnityVideoPlayerFlutter extends UnityVideoPlayer {
if (uri.scheme == 'file') {
player = VideoPlayerController.file(File.fromUri(uri));
} else {
player = VideoPlayerController.networkUrl(uri);
player = VideoPlayerController.networkUrl(
uri,
httpHeaders: headers ?? const <String, String>{},
);
}

try {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -306,13 +306,20 @@ class UnityVideoPlayerMediaKit extends UnityVideoPlayer {
}

@override
Future<void> setDataSource(String url, {bool autoPlay = true}) {
Future<void> setDataSource(
String url, {
bool autoPlay = true,
Map<String, String>? headers,
}) {
if (url == dataSource) return Future.value();
debugPrint('Playing $url');
return ensureVideoControllerInitialized((controller) async {
await mkPlayer.setPlaylistMode(PlaylistMode.loop);
// do not use mkPlayer.add because it doesn't support auto play
await mkPlayer.open(Playlist([Media(url)]), play: autoPlay);
await mkPlayer.open(
Playlist([Media(url, httpHeaders: headers)]),
play: autoPlay,
);
});
}

Expand Down
24 changes: 12 additions & 12 deletions packages/unity_video_player/unity_video_player_main/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ dependencies:
# git:
# url: https://github.com/media-kit/media-kit/
# path: media_kit/
media_kit_native_event_loop:
git:
url: https://github.com/media-kit/media-kit/
path: media_kit_native_event_loop/
# media_kit_native_event_loop:
# git:
# url: https://github.com/media-kit/media-kit/
# path: media_kit_native_event_loop/
# media_kit_video:
# git:
# url: https://github.com/media-kit/media-kit/
Expand Down Expand Up @@ -57,18 +57,18 @@ dev_dependencies:
flutter_lints: ^2.0.0

dependency_overrides:
media_kit:
git:
url: https://github.com/media-kit/media-kit/
path: media_kit/
# media_kit:
# git:
# url: https://github.com/media-kit/media-kit/
# path: media_kit/
#media_kit_native_event_loop:
# git:
# url: https://github.com/media-kit/media-kit/
# path: media_kit_native_event_loop/
media_kit_video:
git:
url: https://github.com/media-kit/media-kit/
path: media_kit_video/
# media_kit_video:
# git:
# url: https://github.com/media-kit/media-kit/
# path: media_kit_video/
# media_kit_libs_android_video:
# git:
# url: https://github.com/media-kit/media-kit/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,11 @@ abstract class UnityVideoPlayer with ChangeNotifier {
/// Whether the media is seekable
bool get isSeekable;

Future<void> setDataSource(String url, {bool autoPlay = true});
Future<void> setDataSource(
String url, {
bool autoPlay = true,
Map<String, String>? headers,
});
Future<void> setMultipleDataSource(
Iterable<String> url, {
bool autoPlay = true,
Expand Down
Loading
Loading