Skip to content

General #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 31, 2025
Merged

General #335

merged 7 commits into from
Mar 31, 2025

Conversation

bdlukaa
Copy link
Collaborator

@bdlukaa bdlukaa commented Mar 28, 2025

  • Use MDK by default on Windows;
    • FPS is now supported with MDK.
    • Errors are now displayed in the stream log file as well.
  • Display build number on bleeding edge release. Fixes Add build number #330

@bdlukaa bdlukaa requested a review from Copilot March 28, 2025 19:12
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates dependency versions and configuration defaults to use MDK by default on Windows, adds FPS support with MDK, and displays errors in the stream log file. It also injects build info (build number and optionally a build name) into various build commands for different targets.

Reviewed Changes

Copilot reviewed 4 out of 7 changed files in this pull request and generated no comments.

File Description
packages/unity_video_player/unity_video_player_flutter/pubspec.yaml Updates the fvp dependency version to support new MDK features.
packages/unity_video_player/unity_video_player/pubspec.yaml Changes the default package for Windows to use unity_video_player_flutter (MDK).
.github/workflows/build.yml Adds extraction of build info and updates build commands to include build number and name.
Files not reviewed (3)
  • lib/screens/settings/updates_and_help.dart: Language not supported
  • lib/utils/video_player.dart: Language not supported
  • packages/unity_video_player/unity_video_player_flutter/lib/unity_video_player_flutter.dart: Language not supported
Comments suppressed due to low confidence (1)

.github/workflows/build.yml:58

  • The use of format('--build-name={0}', env.BUILD_NAME) within the GitHub Actions expression might not be supported. Consider using string concatenation or an alternative method that is compatible with GitHub Actions expression syntax.
      - run: flutter build apk --verbose --split-per-abi --build-number=${{ env.BUILD_NUMBER }} ${{ env.BUILD_NAME && format('--build-name={0}', env.BUILD_NAME) }}

@bdlukaa bdlukaa merged commit ea58751 into main Mar 31, 2025
4 of 9 checks passed
@bdlukaa bdlukaa deleted the general branch March 31, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add build number
1 participant