Optimize memo sync: lazy dirty flags instead of eager cloning#8
Merged
Conversation
The fix in 819b21b cloned the full container into memo after every SETITEMS/APPENDS (sync_memo_top), causing significant decode regression. Replace with lazy approach: mark memo entries as dirty after mutations, resolve only when BINGET reads a stale entry or when pop_value/pop_mark consume the owning stack slot. Most memo entries are never re-read via BINGET, so this eliminates the majority of unnecessary clones. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sync_memo_top()(clones full container after every SETITEMS/APPENDS) with lazy dirty-flag approachBenchmark results (PGO build, 5000 iterations)
Decode median (us)
FileStorage (1,692 real records)
Recovers ~half the regression. Remaining overhead is inherent to value semantics — when a dirty memo'd container is popped from the stack, we must clone it into memo. Only reference semantics (Rc) could eliminate this, but that was previously tried and regressed worse overall.
Test plan
cargo test— 200 tests pass (incl. 2 regression tests from #18)pytest tests/— 182 Python tests pass🤖 Generated with Claude Code