[DRAFT] Changes to generate bindings for the android-sdk#14
Draft
simlay wants to merge 11 commits intobluejekyll:mainfrom
Draft
[DRAFT] Changes to generate bindings for the android-sdk#14simlay wants to merge 11 commits intobluejekyll:mainfrom
simlay wants to merge 11 commits intobluejekyll:mainfrom
Conversation
Owner
|
Thanks for taking an interest in this! I’m happy to get some new changes in. |
simlay
commented
May 13, 2024
Comment on lines
+23
to
+45
| impl<'j> FromJavaToRust<'j, Self> for UnsupportedArray<'j> { | ||
| fn java_to_rust(java: Self, _env: JNIEnv<'j>) -> Self { | ||
| java | ||
| } | ||
| } | ||
| impl<'j> Deref for UnsupportedArray<'j> { | ||
| type Target = JObject<'j>; | ||
|
|
||
| fn deref(&self) -> &Self::Target { | ||
| &self.0 | ||
| } | ||
| } | ||
| impl<'j> FromRustToJava<'j, Self> for UnsupportedArray<'j> { | ||
| fn rust_to_java(rust: Self, _env: JNIEnv<'j>) -> Self { | ||
| rust | ||
| } | ||
| } | ||
| impl<'j> From<JObject<'j>> for UnsupportedArray<'j> { | ||
| fn from(jobject: JObject<'j>) -> Self { | ||
| Self(jobject) | ||
| } | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
If I'm understanding this correctly, an UnsupportedArray should be unsupported. It's unclear what this should be though.
Owner
There was a problem hiding this comment.
I forget why I created this... It might have just been types that we didn't recognize?
Merged
simlay
force-pushed
the
android-bindings
branch
from
6155f4f to
ea7b3e3
Compare
* Added support for generating modules * Add workflow disptach option to ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there, not sure if this repo is still maintained but figured I'd add some WIP changes.
In a possibly foolish attempt, I've been messing around with generating bindings for the android sdk. The changes in this PR are needed for generating bindings.
A non-exhaustive list of the changes:
FromRustToJavaand other traits forUnsupportedArray