[WIP] Improve windows support #120
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…luejekyll/pg-extend-rs into improve-test-feature-execution
…luejekyll/pg-extend-rs into improve-test-feature-execution
…luejekyll/pg-extend-rs into improve-test-feature-execution
# Conflicts: # examples/adding/src/lib.rs
auterium
commented
Jan 3, 2020
| #[cfg(windows)] | ||
| fn main() { | ||
| const LIB_NAME: &str = env!("CARGO_PKG_NAME"); | ||
| let lib_name = env!("CARGO_PKG_NAME").replace("-", "_"); |
There was a problem hiding this comment.
When building, the resulting files will always use underscores, so we need to replace dashes with underscores, otherwise there's a mismatch
auterium
commented
Jan 3, 2020
| else { | ||
| panic!("Cannot mix Option and non-Option arguments."); | ||
| } | ||
| if !optional_args.iter().any(|&x| x) { " STRICT" } |
There was a problem hiding this comment.
This allows for mixing Option with non-Option arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
eprintln!()we can at least avoid crashes and write to PG log.&[T]support: only execute unsafe code inside unsafe blocks; safe code moved out of unsafe blocksrustflagsfor Windows builds (pointing topostgres.lib)