helper: raise timeout to 2 seconds, try probing up to 3 times by default #2847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Williangalvani
force-pushed
the
helper_tweaks
branch
from
5769270
to
201c7f1
Compare
Williangalvani
changed the title
core/services/helper/main.py
Outdated
| @@ -305,14 +305,18 @@ def simple_http_request( | |||
|
|
|||
| @staticmethod | |||
| @temporary_cache(timeout_seconds=1) # a temporary cache helps us deal with changes in metadata | |||
There was a problem hiding this comment.
We should update the timeout as well
Williangalvani
force-pushed
the
helper_tweaks
branch
from
201c7f1
to
248e80d
Compare
|
I think the retries should be implemented inside the Helper.simple_http_request instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as the issue is hard to replicate, I'll be running this image for a while.
should fix #2846