-
Notifications
You must be signed in to change notification settings - Fork 38
feat: add program extend command for upgradeable programs #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
rebase against #101 and construct from there :) |
139457e to
e4cdd52
Compare
BretasArthur1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm, lets wait naga
90419d4 to
59f698e
Compare
|
hey @AvhiMaz rebase this one pls |
362f85a to
334ae8c
Compare
Signed-off-by: AvhiMaz <avhimazumder5@outlook.com>
Signed-off-by: AvhiMaz <avhimazumder5@outlook.com>
Signed-off-by: AvhiMaz <avhimazumder5@outlook.com>
Signed-off-by: AvhiMaz <avhimazumder5@outlook.com>
334ae8c to
db7a171
Compare
Signed-off-by: AvhiMaz <avhimazumder5@outlook.com>
Nagaprasadvr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im working on program deploy , will push it soon lets wait till then so we are on the same page
|
|
||
| pub const MEMO_PROGRAM_ID: &str = "MemoSq4gqABAXKb96qnH8TysNcWxMyWCqXgDLGmfcHr"; | ||
|
|
||
| pub const MAX_PERMITTED_DATA_LENGTH: usize = 10 * 1024 * 1024; // 10MB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need more context here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more explanation ?
something like:
/// Chosen to stay within Solana account size limits and avoid OOM during CPI.
pub const MAX_PERMITTED_DATA_LENGTH: usize = 10 * 1024 * 1024; // 10MB
okay sir 🫡 |
is the program deployment done ?? |
sir naga is working on it |
Description
Implements the Program command group with the Extend subcommand to support extending
the length of upgradeable Solana programs, enabling deployment of larger programs.
Fixes #96
Type of Change
Before Submitting
masterbranchCode Quality
make all-checksand all checks pass