Properly dispose of unused undici HTTP responses (#3344)

Properly dispose of unused http responses
bluesky-social · Jan 9, 2025 · 48a0e9d · 48a0e9d
1 parent 9dc7251
commit 48a0e9d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/.changeset/afraid-peas-tan.md b/.changeset/afraid-peas-tan.md
@@ -0,0 +1,6 @@
+---
+"@atproto/dev-env": patch
+"@atproto/ozone": patch
+---
+
+Properly dispose of unused http responses
diff --git a/packages/dev-env/src/util.ts b/packages/dev-env/src/util.ts
@@ -45,7 +45,7 @@ export const mockResolvers = (idResolver: IdResolver, pds: TestPds) => {
     try {
       const res = await request(url, { headers: { host: handle } })
       if (res.statusCode !== 200) {
-        res.body.destroy()
+        await res.body.dump()
         return undefined
       }
 

diff --git a/packages/ozone/src/daemon/blob-diverter.ts b/packages/ozone/src/daemon/blob-diverter.ts
@@ -46,7 +46,7 @@ export class BlobDiverter {
       })
 
     if (blobResponse.statusCode !== 200) {
-      blobResponse.body.destroy()
+      await blobResponse.body.dump()
       throw new XRPCError(
         blobResponse.statusCode,
         undefined,
@@ -72,7 +72,7 @@ export class BlobDiverter {
       }
     } catch (err) {
       // Typically un-supported content encoding
-      blobResponse.body.destroy()
+      await blobResponse.body.dump()
       throw err
     }
   }
@@ -99,7 +99,7 @@ export class BlobDiverter {
       })
 
     if (result.statusCode !== 200) {
-      result.body.destroy()
+      await result.body.dump()
       throw new XRPCError(
         result.statusCode,
         undefined,